From: Stefan Lengfeld <contact@stefanchrist.eu>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: nitrogen6: remove hard coded values
Date: Fri, 6 Mar 2020 17:06:03 +0100 [thread overview]
Message-ID: <20200306160603.7it2ljm22lge4jwe@porty> (raw)
In-Reply-To: <20200303174616.4476-3-m.felsch@pengutronix.de>
Hi Marco,
my two cents:
On Tue, Mar 03, 2020 at 06:46:16PM +0100, Marco Felsch wrote:
> Since commit c3f5ce7308 ("net: phy: micrel: Add support for specifying pad
> skew values") and commit 2720a02e8a ("net: phy: micrel: backport finding
> PHY properties") the phy driver can handle this taking the DT specified
The first commit id 'c3f5ce7308' is a *stable* commit id, because
Sascha's 'master' branch of the barebox already contains the
patch/commit. It's safe to use it in commit messages and e.g. 'Fixes:'
tags.
The second commit id '2720a02e8a' is not stable, because the patch is
part of your series and therefore not yet in Sascha's master branch.
When Sascha applies the patch to his git tree, the patch will have a
different commit id, because it will have a different parent, committer
and date.
If you want to reference a patch in your series from a commit message,
you mostly just use something like 'and the previous patch (...)'.
Kind regards,
Stefan
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-03-06 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 17:46 [PATCH 1/3] ARM: nitrogen6x: add phy reset timings Marco Felsch
2020-03-03 17:46 ` [PATCH 2/3] net: phy: micrel: backport finding PHY properties Marco Felsch
2020-03-09 7:28 ` Sascha Hauer
2020-03-03 17:46 ` [PATCH 3/3] ARM: nitrogen6: remove hard coded values Marco Felsch
2020-03-06 16:06 ` Stefan Lengfeld [this message]
2020-03-09 6:32 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306160603.7it2ljm22lge4jwe@porty \
--to=contact@stefanchrist.eu \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox