From: Sam Ravnborg <sam@ravnborg.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support
Date: Sun, 8 Mar 2020 22:38:31 +0100 [thread overview]
Message-ID: <20200308213831.GA22724@ravnborg.org> (raw)
In-Reply-To: <4e33894d-54ce-89b5-7ba9-7541ade184fa@pengutronix.de>
Hi Ahmad.
On Fri, Mar 06, 2020 at 07:06:26AM +0100, Ahmad Fatoum wrote:
> Hi Sam,
>
> On 3/5/20 9:37 PM, Sam Ravnborg wrote:
> >> +#define sama5d2_pmc_enable_periph_clock(clk) \
> >> + at91_pmc_sam9x5_enable_periph_clock(IOMEM(SAMA5D2_BASE_PMC), clk)
> > I see no point in this macro. It is not that this can change or will be
> > reused by others.
>
> It makes the code less verbose IMO.
Had this been a static inline function I would not have commented on
this.
But a define is not the way to do this, a define is something you revert
to if there is no better wyas to do it.
Or so I am teached at least.
Anyway - this is becoming pure bikeshed.
So if I did not do so then with the cargo cult stuff fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
>
> >> + arm_setup_stack(SAMA5D2_SRAM_BASE + SAMA5D2_SRAM_SIZE - 16);
> > This " - 16" is it cargo cult copied from somewhere else?
> > Or does it really matter?
>
> It's cargo cult. Will remove it. I wrote the patch few months ago, Sascha
> has since removed other instances of this cargo cult.
>
> > The rest looked fine to me.
>
> Thanks for taking the time to look though :-)
>
> Cheers,
> Ahmad
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-03-08 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 8:02 [PATCH 1/2] ARM: at91: add support for SAM9 SoC reset Ahmad Fatoum
2020-03-05 8:02 ` [PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support Ahmad Fatoum
2020-03-05 20:37 ` Sam Ravnborg
2020-03-06 6:06 ` Ahmad Fatoum
2020-03-08 21:38 ` Sam Ravnborg [this message]
2020-03-05 20:29 ` [PATCH 1/2] ARM: at91: add support for SAM9 SoC reset Sam Ravnborg
2020-03-06 6:00 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308213831.GA22724@ravnborg.org \
--to=sam@ravnborg.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox