Re: [PATCH 3/3] ARM: nitrogen6: remove hard coded values

[Marco Felsch <m.felsch@pengutronix.de>]

Hi Stefan,

On 20-03-06 17:06, Stefan Lengfeld wrote:
> Hi Marco,
> 
> my two cents:
> 
> On Tue, Mar 03, 2020 at 06:46:16PM +0100, Marco Felsch wrote:
> > Since commit c3f5ce7308 ("net: phy: micrel: Add support for specifying pad
> > skew values") and commit 2720a02e8a ("net: phy: micrel: backport finding
> > PHY properties") the phy driver can handle this taking the DT specified
> 
> The first commit id 'c3f5ce7308' is a *stable* commit id, because
> Sascha's 'master' branch of the barebox already contains the
> patch/commit. It's safe to use it in commit messages and e.g. 'Fixes:'
> tags.

I don't add such tags for barebox because it doesn't make sense here.

> The second commit id '2720a02e8a' is not stable, because the patch is
> part of your series and therefore not yet in Sascha's master branch.
> When Sascha applies the patch to his git tree, the patch will have a
> different commit id, because it will have a different parent, committer
> and date.

You're right here, I imagined it after I send the patch series..
@Sascha
Pls, can you drop the commit-id or adapt it after you applied the patch?

> If you want to reference a patch in your series from a commit message,
> you mostly just use something like 'and the previous patch (...)'.

I will keep that in mind, thanks :)

Regards,
  Marco

> Kind regards,
> Stefan
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox