* [PATCH] pinctrl-single: fix parsing of `pinctrl-single, bits` property
@ 2020-03-12 20:39 Peter Mamonov
2020-03-16 11:27 ` [PATCH] pinctrl-single: fix parsing of `pinctrl-single,bits` property Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Peter Mamonov @ 2020-03-12 20:39 UTC (permalink / raw)
To: s.hauer; +Cc: barebox, Peter Mamonov
According to dts/Bindings/pinctrl/pinctrl-single.txt:113 the correct order of
parameters is <offset, value, mask>.
Fixes: f7e0cae43 ('pinctrl-single: Handle "pinctrl-single,function-mask" dt property')
Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
---
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index d4f411b4a..2cd58df93 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -87,8 +87,8 @@ static int pcs_set_state(struct pinctrl_device *pdev, struct device_node *np)
for (i = 0; i < rows; i++) {
offset = be32_to_cpup(mux + index++);
- mask = be32_to_cpup(mux + index++);
val = be32_to_cpup(mux + index++);
+ mask = be32_to_cpup(mux + index++);
reg = pcs->read(pcs->base + offset);
reg &= ~mask;
reg |= val;
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl-single: fix parsing of `pinctrl-single,bits` property
2020-03-12 20:39 [PATCH] pinctrl-single: fix parsing of `pinctrl-single, bits` property Peter Mamonov
@ 2020-03-16 11:27 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-03-16 11:27 UTC (permalink / raw)
To: Peter Mamonov; +Cc: barebox
On Thu, Mar 12, 2020 at 11:39:57PM +0300, Peter Mamonov wrote:
> According to dts/Bindings/pinctrl/pinctrl-single.txt:113 the correct order of
> parameters is <offset, value, mask>.
>
> Fixes: f7e0cae43 ('pinctrl-single: Handle "pinctrl-single,function-mask" dt property')
> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> ---
> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index d4f411b4a..2cd58df93 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -87,8 +87,8 @@ static int pcs_set_state(struct pinctrl_device *pdev, struct device_node *np)
>
> for (i = 0; i < rows; i++) {
> offset = be32_to_cpup(mux + index++);
> - mask = be32_to_cpup(mux + index++);
> val = be32_to_cpup(mux + index++);
> + mask = be32_to_cpup(mux + index++);
> reg = pcs->read(pcs->base + offset);
> reg &= ~mask;
> reg |= val;
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-16 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 20:39 [PATCH] pinctrl-single: fix parsing of `pinctrl-single, bits` property Peter Mamonov
2020-03-16 11:27 ` [PATCH] pinctrl-single: fix parsing of `pinctrl-single,bits` property Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox