mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Peter Mamonov <pmamonov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] serial: ns16550: select default pinctrl state
Date: Fri, 13 Mar 2020 14:27:04 +0300	[thread overview]
Message-ID: <20200313112703.GB8219@localhost.localdomain> (raw)
In-Reply-To: <20200313090326.GK3335@pengutronix.de>

On Fri, Mar 13, 2020 at 10:03:26AM +0100, Sascha Hauer wrote:
> On Thu, Mar 12, 2020 at 11:46:07PM +0300, Peter Mamonov wrote:
> > Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> > ---
> >  drivers/serial/serial_ns16550.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> > index 3edeb0dcb..6b5e92c13 100644
> > --- a/drivers/serial/serial_ns16550.c
> > +++ b/drivers/serial/serial_ns16550.c
> > @@ -39,6 +39,7 @@
> >  #include <malloc.h>
> >  #include <io.h>
> >  #include <linux/clk.h>
> > +#include <pinctrl.h>
> >  
> >  #include "serial_ns16550.h"
> >  #include <platform_data/serial-ns16550.h>
> > @@ -347,6 +348,8 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv)
> >  		dev_err(dev, "unsupported reg-io-width (%d)\n",
> >  			width);
> >  	}
> > +
> > +	of_pinctrl_select_state_default(np);
> 
> Why? This should have been done by the core already at this point.

I struggled with this problem 
http://lists.infradead.org/pipermail/barebox/2020-March/041206.html yesterday, 
and my first guess was that pinctrl doesn't apply. So I made this patch and 
didn't revert it after finding the real solution. I will do so later. Thanks 
for explanation!

Peter

> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-03-13 11:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 20:46 Peter Mamonov
2020-03-13  9:03 ` Sascha Hauer
2020-03-13 11:27   ` Peter Mamonov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313112703.GB8219@localhost.localdomain \
    --to=pmamonov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox