From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCiT8-0004L4-GG for barebox@lists.infradead.org; Fri, 13 Mar 2020 11:27:12 +0000 Received: by mail-lj1-x243.google.com with SMTP id e18so10077713ljn.12 for ; Fri, 13 Mar 2020 04:27:08 -0700 (PDT) Date: Fri, 13 Mar 2020 14:27:04 +0300 From: Peter Mamonov Message-ID: <20200313112703.GB8219@localhost.localdomain> References: <20200312204607.24096-1-pmamonov@gmail.com> <20200313090326.GK3335@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200313090326.GK3335@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC] serial: ns16550: select default pinctrl state To: Sascha Hauer Cc: barebox@lists.infradead.org On Fri, Mar 13, 2020 at 10:03:26AM +0100, Sascha Hauer wrote: > On Thu, Mar 12, 2020 at 11:46:07PM +0300, Peter Mamonov wrote: > > Signed-off-by: Peter Mamonov > > --- > > drivers/serial/serial_ns16550.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c > > index 3edeb0dcb..6b5e92c13 100644 > > --- a/drivers/serial/serial_ns16550.c > > +++ b/drivers/serial/serial_ns16550.c > > @@ -39,6 +39,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "serial_ns16550.h" > > #include > > @@ -347,6 +348,8 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv) > > dev_err(dev, "unsupported reg-io-width (%d)\n", > > width); > > } > > + > > + of_pinctrl_select_state_default(np); > > Why? This should have been done by the core already at this point. I struggled with this problem http://lists.infradead.org/pipermail/barebox/2020-March/041206.html yesterday, and my first guess was that pinctrl doesn't apply. So I made this patch and didn't revert it after finding the real solution. I will do so later. Thanks for explanation! Peter > > Sascha > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox