From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJBeN-0005ML-2g for barebox@lists.infradead.org; Tue, 31 Mar 2020 07:49:32 +0000 Date: Tue, 31 Mar 2020 09:49:29 +0200 From: Sascha Hauer Message-ID: <20200331074929.GJ27288@pengutronix.de> References: <20200330145717.667403-1-ahmad@a3f.at> <20200330145717.667403-13-ahmad@a3f.at> <20200331064120.GH27288@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 12/12] PWM: add support for STM32 To: Ahmad Fatoum Cc: barebox@lists.infradead.org, Ahmad Fatoum On Tue, Mar 31, 2020 at 08:49:33AM +0200, Ahmad Fatoum wrote: > Hello, > > On 3/31/20 8:41 AM, Sascha Hauer wrote: > >> + pwm1 = &{/soc/timer@44000000/pwm}; > >> + pwm2 = &{/soc/timer@40000000/pwm}; > >> + pwm3 = &{/soc/timer@40001000/pwm}; > >> + pwm4 = &{/soc/timer@40002000/pwm}; > >> + pwm5 = &{/soc/timer@40003000/pwm}; > >> + pwm8 = &{/soc/timer@44001000/pwm}; > >> + pwm12 = &{/soc/timer@40006000/pwm}; > >> + pwm13 = &{/soc/timer@40007000/pwm}; > >> + pwm14 = &{/soc/timer@40008000/pwm}; > >> + pwm15 = &{/soc/timer@44006000/pwm}; > >> + pwm16 = &{/soc/timer@44007000/pwm}; > >> + pwm17 = &{/soc/timer@44008000/pwm}; > > > > The other aliases start counting at 0. Why not the PWMs? > > I named them to match the SoC data sheet, > > The final device names are e.g. pwm12ch2, corresponding to TIM12_CH2 > in the SoC datasheet. It's IMO the best user experience, because otherwise > you'll always have to look at the aliases in barebox to determine, > which PWM corresponds to what's printed in the schematics. ok. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox