From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJVnr-00071m-0z for barebox@lists.infradead.org; Wed, 01 Apr 2020 05:20:40 +0000 Date: Wed, 1 Apr 2020 07:20:34 +0200 From: Sascha Hauer Message-ID: <20200401052034.GS27288@pengutronix.de> References: <20200331184722.22707-1-andrew.smirnov@gmail.com> <20200331184722.22707-2-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331184722.22707-2-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 01/23] ARM: zii-common: Gate rdu_i210_invm() call with CONFIG_PCI_IMX6 To: Andrey Smirnov Cc: Barebox List On Tue, Mar 31, 2020 at 11:47:00AM -0700, Andrey Smirnov wrote: > There's no reason to have rdu_i210_invm() inicalli if CONFIG_PCI_IMX6 > is not selected. Add appropriate ifdef to handle that. Either this is the wrong way round... > > Signed-off-by: Andrey Smirnov > --- > arch/arm/boards/zii-common/board.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boards/zii-common/board.c b/arch/arm/boards/zii-common/board.c > index 7bd3a6cab..08e2f8b9b 100644 > --- a/arch/arm/boards/zii-common/board.c > +++ b/arch/arm/boards/zii-common/board.c > @@ -104,6 +104,8 @@ static int rdu_networkconfig(void) > } > late_initcall(rdu_networkconfig); > > +#ifdef CONFIG_PCI_IMX6 ...or this should be #ifndef Sascha > + > #define I210_CFGWORD_PCIID_157B 0x157b1a11 > static int rdu_i210_invm(void) > { > @@ -136,3 +138,5 @@ static int rdu_i210_invm(void) > return 0; > } > late_initcall(rdu_i210_invm); > + > +#endif > -- > 2.21.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox