From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] mfd: rave-sp: Fix rave_sp_emulated_get_status()
Date: Wed, 1 Apr 2020 07:52:52 +0200 [thread overview]
Message-ID: <20200401055252.GY27288@pengutronix.de> (raw)
In-Reply-To: <20200331172252.9703-1-andrew.smirnov@gmail.com>
On Tue, Mar 31, 2020 at 10:22:52AM -0700, Andrey Smirnov wrote:
> Original code in rave_sp_emulated_get_status() got the meaning of
> RAVE_SP_STATUS_GS_FIRMWARE_MODE wrong. Invert it to correctly detect
> if RAVE SP device is in bootloader mode or not.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/mfd/rave-sp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> index 67f7d4c65..c6ad57d51 100644
> --- a/drivers/mfd/rave-sp.c
> +++ b/drivers/mfd/rave-sp.c
> @@ -661,7 +661,7 @@ static int rave_sp_emulated_get_status(struct rave_sp *sp,
> return ret;
>
> status->general_status =
> - firmware_mode ? RAVE_SP_STATUS_GS_FIRMWARE_MODE : 0;
> + firmware_mode ? 0 : RAVE_SP_STATUS_GS_FIRMWARE_MODE;
>
> return 0;
> }
> --
> 2.21.0
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-04-01 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 17:22 Andrey Smirnov
2020-04-01 5:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401055252.GY27288@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox