From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! regmap-mmio: Add big endian support
Date: Tue, 14 Apr 2020 09:14:45 +0200 [thread overview]
Message-ID: <20200414071445.GW27288@pengutronix.de> (raw)
In-Reply-To: <20200413071111.20443-1-a.fatoum@pengutronix.de>
On Mon, Apr 13, 2020 at 09:11:11AM +0200, Ahmad Fatoum wrote:
> ("regmap-mmio: Add big endian support") required syscons to have a device_d
> instantiated for them. This doesn't work for clock drivers though,
> like the sama5d2's, because of_clk_init is called before
> of_platform_populate allocates the devices.
>
> Restore the old behavior by passing NULL to regmap_init_mmio_clk again.
> Because we want syscons to be endianness aware, do as Linux does and
> duplicate the device tree endianness retrieval in the syscon driver.
>
> [Note: Clock drivers wishing to make use of this should take care to not
> call syscon_node_to_regmap on a node with a clocks property as this
> will probably fail. This is the Linux behavior. A safer
> device_node_to_regmap will be introduced in a separate series that
> ignores clocks. ]
> ---
> Hopefully my last fixup for this, I think I got it right now.
I hope that as well ;)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-14 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 7:11 Ahmad Fatoum
2020-04-14 7:14 ` Sascha Hauer [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-31 17:26 Ahmad Fatoum
2020-04-01 5:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414071445.GW27288@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox