From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands/*: Replace license boilerplate by SPDX identfiers
Date: Tue, 21 Apr 2020 23:08:27 +0200 [thread overview]
Message-ID: <20200421210827.ivvwaostkssofq2q@pengutronix.de> (raw)
In-Reply-To: <20200420084657.7vqzmu5g5aj63sza@pengutronix.de>
Hello Roland,
On Mon, Apr 20, 2020 at 10:46:57AM +0200, Roland Hieber wrote:
> On Fri, Apr 17, 2020 at 10:33:08PM +0200, Uwe Kleine-König wrote:
> > While at it also drop references to the non-existing CREDITS file.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> >
> > there is one file (2048.c) that specifies the MIT license. I wonder if
> > we should use "GPL-2.0 OR MIT" there as effectively as distributed with
> > barebox it is licensed under the GPL 2, isn't it?
>
> I would stay as close to the source as possible. MIT and GPL-2.0 are
> compatible, so there is no problem on the project level, and I see no
> reason to handle this on the level of individual files.
fine for me.
> > diff --git a/commands/2048.c b/commands/2048.c
> > index 865803a5a616..f5f86940e80e 100644
> > --- a/commands/2048.c
> > +++ b/commands/2048.c
> > @@ -1,6 +1,5 @@
> > +// SPDX-License-Identifier: MIT
> > /*
> > - * The MIT License (MIT)
> > - *
> > * Copyright (c) 2014 Maurits van der Schee
> > *
> > * Permission is hereby granted, free of charge, to any person obtaining a copy
>
> These boilerplate lines could be removed too.
I wasn't sure this is the right thing as "The above copyright notice and
this permission notice shall be included in all copies or substantial
portions of the Software." Probably this is not relevant when we include
the license as Ahmad pointed out.
> > +// SPDX-License-Identifier: GPL-2.0+
>
> GPL-2.0+ is the old-style identifier, which is deprecated by SPDX (see
> https://spdx.org/licenses/ at the bottom). I think we should also use
> new-style GPL-2.0-or-later or GPL-2.0-only here.
>
> The rest looks okay. Thanks for picking this up!
Thanks for looking through the patch and giving feedback.
Will send a revised patch later (or tomorrow).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-21 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 20:33 Uwe Kleine-König
2020-04-20 8:46 ` Roland Hieber
2020-04-21 8:15 ` Ahmad Fatoum
2020-04-21 21:08 ` Uwe Kleine-König [this message]
2020-04-20 12:55 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421210827.ivvwaostkssofq2q@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox