From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v2 2/2] commands/*: Replace license and copyright boilerplate by SPDX identfiers
Date: Thu, 23 Apr 2020 12:16:31 +0200 [thread overview]
Message-ID: <20200423101631.rwqopetiy52nr77r@pengutronix.de> (raw)
In-Reply-To: <20200423081324.tzfe67tx4ah7krnm@pengutronix.de>
Hello Roland,
On Thu, Apr 23, 2020 at 10:13:24AM +0200, Roland Hieber wrote:
> It's already applied now, but for the future, such large patches are
> really easier to review when they do only one thing at a time (replacing
> the boilerplate with license identifiers, changing copyright tags,
> changing old to new identifiers, adding new identifiers etc.).
>
> That that, I couldn't find any errors, but that doesn't mean there
> aren't any. :)
That's one side of the coin. The other is that several patches touching
all the same area result in more work to create the patches and make
patch and commit handling more complicated. While I agree in general
that one-patch-does-one-thing is a good concept I think for
rearrangements like this fixing all files in a directory in one go is
fine. Otherwise the result are patches that just add empty lines before
comments which IMHO doens't justify a patch. Doing this en passant is
fine however.
Sascha, what's your position here?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-23 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 21:15 [PATCH v2 1/2] LICENSES: Add MIT license Uwe Kleine-König
2020-04-21 21:15 ` [PATCH v2 2/2] commands/*: Replace license and copyright boilerplate by SPDX identfiers Uwe Kleine-König
2020-04-23 8:13 ` Roland Hieber
2020-04-23 10:16 ` Uwe Kleine-König [this message]
2020-04-27 7:09 ` Sascha Hauer
2020-04-23 6:25 ` [PATCH v2 1/2] LICENSES: Add MIT license Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423101631.rwqopetiy52nr77r@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox