From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Roland Hieber <rhi@pengutronix.de>
Subject: Re: [PATCH v2 2/2] commands/*: Replace license and copyright boilerplate by SPDX identfiers
Date: Mon, 27 Apr 2020 09:09:56 +0200 [thread overview]
Message-ID: <20200427070956.GK5877@pengutronix.de> (raw)
In-Reply-To: <20200423101631.rwqopetiy52nr77r@pengutronix.de>
On Thu, Apr 23, 2020 at 12:16:31PM +0200, Uwe Kleine-König wrote:
> Hello Roland,
>
> On Thu, Apr 23, 2020 at 10:13:24AM +0200, Roland Hieber wrote:
> > It's already applied now, but for the future, such large patches are
> > really easier to review when they do only one thing at a time (replacing
> > the boilerplate with license identifiers, changing copyright tags,
> > changing old to new identifiers, adding new identifiers etc.).
> >
> > That that, I couldn't find any errors, but that doesn't mean there
> > aren't any. :)
>
> That's one side of the coin. The other is that several patches touching
> all the same area result in more work to create the patches and make
> patch and commit handling more complicated. While I agree in general
> that one-patch-does-one-thing is a good concept I think for
> rearrangements like this fixing all files in a directory in one go is
> fine. Otherwise the result are patches that just add empty lines before
> comments which IMHO doens't justify a patch. Doing this en passant is
> fine however.
>
> Sascha, what's your position here?
Well one-patch-does-one-thing is nice and important for me when doing
code changes, but in this case I think reviewing the patch is
sufficiently easy, splitting it up is unnecessary work.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-27 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 21:15 [PATCH v2 1/2] LICENSES: Add MIT license Uwe Kleine-König
2020-04-21 21:15 ` [PATCH v2 2/2] commands/*: Replace license and copyright boilerplate by SPDX identfiers Uwe Kleine-König
2020-04-23 8:13 ` Roland Hieber
2020-04-23 10:16 ` Uwe Kleine-König
2020-04-27 7:09 ` Sascha Hauer [this message]
2020-04-23 6:25 ` [PATCH v2 1/2] LICENSES: Add MIT license Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427070956.GK5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rhi@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox