From: Clement Leger <cleger@kalray.eu>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Cc: Clement Leger <cleger@kalray.eu>
Subject: [PATCH v3 4/7] common: elf: add elf_open, elf_close and elf_load
Date: Tue, 28 Apr 2020 09:50:57 +0200 [thread overview]
Message-ID: <20200428075100.17565-5-cleger@kalray.eu> (raw)
In-Reply-To: <20200428075100.17565-1-cleger@kalray.eu>
When loading an elf file from a mtd device, this allows to parse the
header and load only the needed data according to the elf size. Without
that support, loading a elf file from a /dev/mtd would try to read the
entire partition. Finally, split elf open and segment loading to allow
loading segment separately when using bootm_load_os.
Signed-off-by: Clement Leger <cleger@kalray.eu>
---
common/elf.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++++++
include/elf.h | 8 +++++
2 files changed, 100 insertions(+)
diff --git a/common/elf.c b/common/elf.c
index 5534632b2..9edd2742f 100644
--- a/common/elf.c
+++ b/common/elf.c
@@ -5,7 +5,12 @@
#include <common.h>
#include <elf.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <libfile.h>
#include <memory.h>
+#include <unistd.h>
+#include <linux/fs.h>
struct elf_section {
struct list_head list;
@@ -158,3 +163,90 @@ void elf_release_image(struct elf_image *elf)
free(elf);
}
+
+int elf_load(struct elf_image *elf)
+{
+ int ret;
+
+ ret = load_elf_image_phdr(elf);
+ if (ret)
+ elf_release_regions(elf);
+
+ return ret;
+}
+
+static u64 elf_get_size(struct elf_image *elf)
+{
+ u64 sh_size = elf_hdr_e_shentsize(elf, elf->buf) *
+ elf_hdr_e_shnum(elf, elf->buf);
+
+ /*
+ * The section header table is located at the end of the elf file thus
+ * we can take the offset and add the size of this table to obtain the
+ * file size.
+ */
+ return elf_hdr_e_shoff(elf, elf->buf) + sh_size;
+}
+
+struct elf_image *elf_open(const char *filename)
+{
+ int fd, ret;
+ u64 size;
+ struct elf64_hdr hdr;
+ struct elf_image *elf;
+ ssize_t read_ret;
+
+ fd = open(filename, O_RDONLY);
+ if (fd < 0) {
+ printf("could not open: %s\n", errno_str());
+ return ERR_PTR(-errno);
+ }
+
+ if (read(fd, &hdr, sizeof(hdr)) < 0) {
+ printf("could not read elf header: %s\n", errno_str());
+ ret = -errno;
+ goto err_close_fd;
+ }
+
+ elf = xzalloc(sizeof(*elf));
+
+ ret = elf_check_init(elf, &hdr);
+ if (ret) {
+ ret = -errno;
+ goto err_free_elf;
+ }
+
+ size = elf_get_size(elf);
+
+ elf->buf = malloc(size);
+ if (!elf->buf) {
+ ret = -ENOMEM;
+ goto err_free_elf;
+ }
+
+ lseek(fd, 0, SEEK_SET);
+
+ read_ret = read_full(fd, elf->buf, size);
+ if (read_ret < 0) {
+ printf("could not read elf file: %s\n", errno_str());
+ ret = -errno;
+ goto err_free_buf;
+ }
+
+ return elf;
+
+err_free_buf:
+ free(elf->buf);
+err_free_elf:
+ free(elf);
+err_close_fd:
+ close(fd);
+
+ return ERR_PTR(ret);
+}
+
+void elf_close(struct elf_image *elf)
+{
+ free(elf->buf);
+ elf_release_image(elf);
+}
diff --git a/include/elf.h b/include/elf.h
index 403412f3f..b36b917e5 100644
--- a/include/elf.h
+++ b/include/elf.h
@@ -416,6 +416,10 @@ static inline size_t elf_get_mem_size(struct elf_image *elf)
struct elf_image *elf_load_image(void *buf);
void elf_release_image(struct elf_image *elf);
+struct elf_image *elf_open(const char *filename);
+void elf_close(struct elf_image *elf);
+int elf_load(struct elf_image *elf);
+
#define ELF_GET_FIELD(__s, __field, __type) \
static inline __type elf_##__s##_##__field(struct elf_image *elf, void *arg) { \
if (elf->class == ELFCLASS32) \
@@ -427,6 +431,10 @@ static inline __type elf_##__s##_##__field(struct elf_image *elf, void *arg) { \
ELF_GET_FIELD(hdr, e_entry, u64)
ELF_GET_FIELD(hdr, e_phnum, u16)
ELF_GET_FIELD(hdr, e_phoff, u64)
+ELF_GET_FIELD(hdr, e_shoff, u64)
+ELF_GET_FIELD(hdr, e_shentsize, u16)
+ELF_GET_FIELD(hdr, e_machine, u16)
+ELF_GET_FIELD(hdr, e_shnum, u16)
ELF_GET_FIELD(hdr, e_type, u16)
ELF_GET_FIELD(phdr, p_paddr, u64)
ELF_GET_FIELD(phdr, p_filesz, u64)
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-28 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 7:50 [PATCH v3 0/7] elf: add better bootm support Clement Leger
2020-04-28 7:50 ` [PATCH v3 1/7] common: elf: add computation of elf boundaries Clement Leger
2020-04-28 7:50 ` [PATCH v3 2/7] common: elf: fix warning on 32 bits architectures Clement Leger
2020-04-28 7:50 ` [PATCH v3 3/7] common: elf: split init to be reused from other function Clement Leger
2020-04-28 7:50 ` Clement Leger [this message]
2020-04-28 7:50 ` [PATCH v3 5/7] common: bootm: add support for elf file loading Clement Leger
2020-04-28 7:50 ` [PATCH v3 6/7] mips: lib: bootm: use bootm elf loading capabilities Clement Leger
2020-04-28 7:51 ` [PATCH v3 7/7] common: elf: remove elf_load_image/elf_release_image Clement Leger
2020-04-29 8:34 ` [PATCH v3 0/7] elf: add better bootm support Oleksij Rempel
2020-04-29 8:55 ` Clément Leger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428075100.17565-5-cleger@kalray.eu \
--to=cleger@kalray.eu \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox