* [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS
@ 2020-05-09 3:02 Masahiro Yamada
2020-05-09 3:02 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada
2020-05-12 5:37 ` [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-05-09 3:02 UTC (permalink / raw)
To: barebox; +Cc: Masahiro Yamada
- Turn Wstrict-prototypes into an error
- Add -Werror=implicit-int
- Use the standard form -Werror=... for implicit-function-declaration
This commit imports the following Linux commits. They should work for
barebox too.
80970472179a Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default
eeb5687a7139 kbuild: add -Werror=strict-prototypes flag unconditionally
61a0902a06d6 kbuild: add -Werror=implicit-int flag unconditionally
b89f25ea7892 kbuild: use -Werror=implicit-... instead of -Werror-implicit-...
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 9485f5551..a732e24d3 100644
--- a/Makefile
+++ b/Makefile
@@ -318,9 +318,10 @@ LINUXINCLUDE := -Iinclude -I$(srctree)/dts/include \
KBUILD_CPPFLAGS := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
-KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
- -Werror-implicit-function-declaration \
- -fno-strict-aliasing -fno-common -Os -pipe -Wmissing-prototypes
+KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
+ -fno-strict-aliasing -fno-common \
+ -Werror=implicit-function-declaration -Werror=implicit-int \
+ -Os -pipe -Wmissing-prototypes
KBUILD_AFLAGS := -D__ASSEMBLY__
LDFLAGS_barebox := -Map barebox.map
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS
2020-05-09 3:02 [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Masahiro Yamada
@ 2020-05-09 3:02 ` Masahiro Yamada
2020-05-12 5:37 ` [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-05-09 3:02 UTC (permalink / raw)
To: barebox; +Cc: Masahiro Yamada
[ Linux commit 735aab1e008b6d9ba8057caa647b6619bf73460f ]
Add -Wall to catch more warnings for C++ host programs.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a732e24d3..be9f2a211 100644
--- a/Makefile
+++ b/Makefile
@@ -198,7 +198,7 @@ HOSTCXX = g++
KBUILD_HOSTCFLAGS := -Wall -Wstrict-prototypes -O2 \
-fomit-frame-pointer $(HOST_LFS_CFLAGS) \
$(HOSTCFLAGS)
-KBUILD_HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS)
+KBUILD_HOSTCXXFLAGS := -Wall -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS)
KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS)
KBUILD_HOSTLDLIBS := $(HOST_LFS_LIBS) $(HOSTLDLIBS)
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS
2020-05-09 3:02 [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Masahiro Yamada
2020-05-09 3:02 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada
@ 2020-05-12 5:37 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2020-05-12 5:37 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: barebox
On Sat, May 09, 2020 at 12:02:38PM +0900, Masahiro Yamada wrote:
> - Turn Wstrict-prototypes into an error
> - Add -Werror=implicit-int
> - Use the standard form -Werror=... for implicit-function-declaration
>
> This commit imports the following Linux commits. They should work for
> barebox too.
>
> 80970472179a Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default
> eeb5687a7139 kbuild: add -Werror=strict-prototypes flag unconditionally
> 61a0902a06d6 kbuild: add -Werror=implicit-int flag unconditionally
> b89f25ea7892 kbuild: use -Werror=implicit-... instead of -Werror-implicit-...
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Applied, thanks
Sascha
>
> Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9485f5551..a732e24d3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -318,9 +318,10 @@ LINUXINCLUDE := -Iinclude -I$(srctree)/dts/include \
>
> KBUILD_CPPFLAGS := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
>
> -KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> - -Werror-implicit-function-declaration \
> - -fno-strict-aliasing -fno-common -Os -pipe -Wmissing-prototypes
> +KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
> + -fno-strict-aliasing -fno-common \
> + -Werror=implicit-function-declaration -Werror=implicit-int \
> + -Os -pipe -Wmissing-prototypes
> KBUILD_AFLAGS := -D__ASSEMBLY__
>
> LDFLAGS_barebox := -Map barebox.map
> --
> 2.25.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-12 5:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 3:02 [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Masahiro Yamada
2020-05-09 3:02 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada
2020-05-12 5:37 ` [PATCH 1/2] kbuild: add -Werror={strict-prototypes, implicit-int} to KBUILD_CFLAGS Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox