Re: [PATCH v4 0/7] elf: add better bootm support

[Oleksij Rempel <o.rempel@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 3705 bytes --]

On Sat, May 09, 2020 at 04:51:42PM +0200, Oleksij Rempel wrote:
> Hi Clement,
> 
> suddenly it is still exploding. I'll try to investigate the reason.

common/elf.c:
  load_elf_image_phdr()
    elf_hdr_e_phnum() <-- returns 0
    for (i = 0; i < elf_hdr_e_phnum(elf, buf) ; ++i) {
      ... so we will never get here.

Probably we should add a sanity check here and be more verbose in this
case.

here is my elf image:
https://github.com/olerem/barebox/blob/new-elf/ore-linux-dpt-module

> On Fri, May 08, 2020 at 07:04:04PM +0200, Clement Leger wrote:
> > Currently, when booting an elf file using "bootm /dev/mtdx", bootm will
> > simply pass the file to the bootm and the read done on it will read the
> > entire flash partition. This series starts by some cleanup and then add an
> > elf_open function to load the elf file size only based on the elf header.
> > A special handling for the elf file is also added in bootm data to allow
> > using directly the elf file structure. Finally the mips bootm is modified
> > to use bootm_load_os directly instead of manual elf loading.
> > 
> > Compilation for both mips and arm has been tested but run on qemu-malta was not
> > possible. Changing the MALLOC_SIZE to allow loading a kernel always lead to a 
> > non-bootable system. Changes have been tested on kvx architecture for which
> > bootm support has been added and will be submitted.
> > 
> > Changes v3 -> v4
> >  - Fix init of elf entry address to be used by bootm_load_elf
> > 
> > Changes v2 -> v3
> >  - Integrate elf loading in bootm_load_os
> >  - Add patch to remove now unused elf_load_image/elf_release_image
> >  - Use malloc instead of xmalloc and check return value
> > 
> > Changes v1 -> v2
> >  - Add BOOTM_ELF config to select elf support and add checks in code
> >  - Add an elf_get_mem_size function to avoid computing elf size in bootm.c
> >  - Use xmalloc and read_full in elf_open instead of xzalloc/read
> >  - Fix data->elf NULL reset
> >  - Remove elf struct entirely from mips bootm code
> > 
> > Clement Leger (7):
> >   common: elf: add computation of elf boundaries
> >   common: elf: fix warning on 32 bits architectures
> >   common: elf: split init to be reused from other function
> >   common: elf: add elf_open, elf_close and elf_load
> >   common: bootm: add support for elf file loading
> >   mips: lib: bootm: use bootm elf loading capabilities
> >   common: elf: remove elf_load_image/elf_release_image
> > 
> >  arch/mips/lib/bootm.c |  31 +++++-------
> >  common/Kconfig        |   8 +++
> >  common/bootm.c        |  33 +++++++++++++
> >  common/elf.c          | 111 +++++++++++++++++++++++++++++++++++-------
> >  include/bootm.h       |   3 ++
> >  include/elf.h         |  16 +++++-
> >  6 files changed, 163 insertions(+), 39 deletions(-)
> > 
> > -- 
> > 2.17.1
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox