From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYPdm-0001Vx-LN for barebox@lists.infradead.org; Tue, 12 May 2020 07:47:52 +0000 Date: Tue, 12 May 2020 09:47:49 +0200 From: Sascha Hauer Message-ID: <20200512074749.GD5877@pengutronix.de> References: <20200511164957.21930-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511164957.21930-1-l.stach@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] mci: stm32_sdmmc2: don't retry commands To: Lucas Stach Cc: barebox@lists.infradead.org On Mon, May 11, 2020 at 06:49:56PM +0200, Lucas Stach wrote: > No other MCI does retry failing commands on its own (if at all > this should be done by the MCI core). Remove the retry, as we > don't want to paper over board level issues. > > Signed-off-by: Lucas Stach > --- > drivers/mci/stm32_sdmmc2.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c > index 0c26869b0378..de96f0974489 100644 > --- a/drivers/mci/stm32_sdmmc2.c > +++ b/drivers/mci/stm32_sdmmc2.c > @@ -481,11 +481,8 @@ static int stm32_sdmmc2_send_cmd(struct mci_host *mci, struct mci_cmd *cmd, > { > struct stm32_sdmmc2_priv *priv = to_mci_host(mci); > u32 cmdat = data ? SDMMC_CMD_CMDTRANS : 0; > - u32 data_length; > - int ret, retry = 3; > - > -retry_cmd: > - data_length = 0; > + u32 data_length = 0; > + int ret; > > if (data) { > data_length = data->blocks * data->blocksize; > @@ -530,15 +527,6 @@ retry_cmd: > writel(SDMMC_ICR_STATIC_FLAGS, priv->base + SDMMC_ICR); > } > > - if (ret && retry) { > - dev_warn(priv->dev, "%s: cmd %d failed, retrying ...\n", > - __func__, cmd->cmdidx); > - > - retry--; > - > - goto retry_cmd; > - } > - > dev_dbg(priv->dev, "%s: end for CMD %d, ret = %d\n", __func__, > cmd->cmdidx, ret); > > -- > 2.20.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox