From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: designware: eqos: attach PHY earlier
Date: Tue, 12 May 2020 09:52:00 +0200 [thread overview]
Message-ID: <20200512075200.GF5877@pengutronix.de> (raw)
In-Reply-To: <20200511165038.22358-1-l.stach@pengutronix.de>
On Mon, May 11, 2020 at 06:50:38PM +0200, Lucas Stach wrote:
> If the PHY isn't driving the refclock, the software reset of the
> controller will time out. Some PHYs need some board specific
> configuration to properly drive the reflock. Attach the PHY before
> attempting the software reset, so PHY fixups have a chance to run.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/net/designware_eqos.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
> index cb52f3942d86..d2baaeaf6372 100644
> --- a/drivers/net/designware_eqos.c
> +++ b/drivers/net/designware_eqos.c
> @@ -360,6 +360,11 @@ static int eqos_start(struct eth_device *edev)
> int ret;
> int i;
>
> + ret = phy_device_connect(edev, &eqos->miibus, eqos->phy_addr,
> + eqos->ops->adjust_link, 0, eqos->interface);
> + if (ret)
> + return ret;
> +
> setbits_le32(&eqos->dma_regs->mode, EQOS_DMA_MODE_SWR);
>
> ret = readl_poll_timeout(&eqos->dma_regs->mode, mode_set,
> @@ -379,11 +384,6 @@ static int eqos_start(struct eth_device *edev)
> val = (rate / USEC_PER_SEC) - 1; /* -1 because the data sheet says so */
> writel(val, &eqos->mac_regs->us_tic_counter);
>
> - ret = phy_device_connect(edev, &eqos->miibus, eqos->phy_addr,
> - eqos->ops->adjust_link, 0, eqos->interface);
> - if (ret)
> - return ret;
> -
> /* Before we reset the mac, we must insure the PHY is not powered down
> * as the dw controller needs all clock domains to be running, including
> * the PHY clock, to come out of a mac reset. */
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-05-12 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:50 Lucas Stach
2020-05-12 5:44 ` Ahmad Fatoum
2020-05-12 7:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512075200.GF5877@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox