From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Daniel Glöckner" <dg@emlix.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 08/10] fastboot: rename usbgadget.fastboot_* variables to fastboot.*
Date: Wed, 20 May 2020 06:55:13 +0200 [thread overview]
Message-ID: <20200520045513.GQ11869@pengutronix.de> (raw)
In-Reply-To: <24116d80272b13dc1e38eaf0bb3beb7b2f4a5f79.1589477005.git.dg@emlix.com>
On Thu, May 14, 2020 at 08:21:56PM +0200, Daniel Glöckner wrote:
> There is nothing USB-specific in the defined usbgadget.fastboot_*
> variables. Rename them to be usable also for the UDP fastboot transport.
>
> The usbgadget.fastboot_function variable is used to define the files and
> devices accessible with the erase and flash commands. Since "function" is
> a term from the USB specification and the Fastboot specification uses the
> term "partition", we rename that variable to "fastboot.partitions".
>
> Signed-off-by: Daniel Glöckner <dg@emlix.com>
> ---
> Documentation/user/usb.rst | 4 ++--
> commands/usbgadget.c | 2 +-
> common/fastboot.c | 15 +++++++++++++--
> common/usbgadget.c | 16 ++--------------
> include/fastboot.h | 3 +++
> 5 files changed, 21 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/user/usb.rst b/Documentation/user/usb.rst
> device_initcall(fastboot_globalvars_init);
>
> -BAREBOX_MAGICVAR_NAMED(global_usbgadget_fastboot_max_download_size,
> - global.usbgadget.fastboot_max_download_size,
> +BAREBOX_MAGICVAR_NAMED(global_fastboot_max_download_size,
> + global.fastboot.max_download_size,
> "Fastboot maximum download size");
This renames the magicvar description for this variable, but not the
variable itself.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-20 4:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 18:21 [PATCH v2 00/10] Support for Fastboot over UDP Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 01/10] Remove CONFIG_SLICE Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 02/10] net: fixed-link phys are never acquired Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 03/10] poller: adapt remaining users to API change Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 04/10] Introduce idle slice Daniel Glöckner
2020-05-20 6:03 ` Sascha Hauer
2020-05-14 18:21 ` [PATCH v2 05/10] ratp: use poller to run ratp commands Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 06/10] fastboot: split generic code from USB gadget Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 07/10] defconfigs: update renamed fastboot options Daniel Glöckner
2020-05-14 18:21 ` [PATCH v2 08/10] fastboot: rename usbgadget.fastboot_* variables to fastboot.* Daniel Glöckner
2020-05-20 4:55 ` Sascha Hauer [this message]
2020-05-14 18:21 ` [PATCH v2 09/10] fastboot net: implement fastboot over UDP Daniel Glöckner
2020-05-20 5:52 ` Sascha Hauer
2020-05-20 6:57 ` Daniel Glöckner
2020-05-20 8:14 ` Sascha Hauer
2020-05-20 8:17 ` Sascha Hauer
2020-05-14 18:21 ` [PATCH v2 10/10] fastboot: don't close fd 0 when downloading to ram Daniel Glöckner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520045513.GQ11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dg@emlix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox