mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] treewide: replace commas with semicolons where appropriate
Date: Wed, 20 May 2020 14:05:59 +0200	[thread overview]
Message-ID: <20200520120559.GE11869@pengutronix.de> (raw)
In-Reply-To: <20200518093135.w7btykywr4mhagrn@pengutronix.de>

On Mon, May 18, 2020 at 11:31:35AM +0200, Roland Hieber wrote:
> On Sun, May 17, 2020 at 08:20:39PM +0200, Ahmad Fatoum wrote:
> > Found by searching drivers/ arch/ common/ and lib/ for
> > 
> >  /^\s+[^."/\*\[\s\{\(A-Z][^\[\{\(]*=[^\{\(]+,$/
> > 
> > Because the comma has the lowest precedence in C,
> > this shouldn't result in any functional change.
> > 
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > ---
> >  .../boards/eukrea_cpuimx35/eukrea_cpuimx35.c  |  2 +-
> >  arch/arm/mach-imx/iim.c                       |  6 +++---
> >  arch/nios2/lib/libgcc.c                       | 21 ++++++++++---------
> >  drivers/i2c/busses/i2c-imx-early.c            |  2 +-
> >  drivers/i2c/busses/i2c-imx.c                  |  2 +-
> >  drivers/i2c/busses/i2c-omap.c                 |  2 +-
> >  drivers/mci/stm32_sdmmc2.c                    |  4 ++--
> >  drivers/net/usb/usbnet.c                      | 10 ++++-----
> >  8 files changed, 25 insertions(+), 24 deletions(-)
> > 
> > diff --git a/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c b/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c
> > index 220a484bde80..558bc0791243 100644
> > --- a/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c
> > +++ b/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c
> > @@ -242,7 +242,7 @@ static int eukrea_cpuimx35_core_init(void)
> >  	reg = writel(reg, MX35_CCM_BASE_ADDR + MX35_CCM_CGR0);
> >  	reg = readl(MX35_CCM_BASE_ADDR + MX35_CCM_CGR1);
> >  	reg |= 0x3 << MX35_CCM_CGR1_FEC_SHIFT;
> > -	reg |= 0x3 << MX35_CCM_CGR1_I2C1_SHIFT,
> > +	reg |= 0x3 << MX35_CCM_CGR1_I2C1_SHIFT;
> >  	reg = writel(reg, MX35_CCM_BASE_ADDR + MX35_CCM_CGR1);
> >  	reg = readl(MX35_CCM_BASE_ADDR + MX35_CCM_CGR2);
> >  	reg |= 0x3 << MX35_CCM_CGR2_USB_SHIFT;
> > diff --git a/arch/arm/mach-imx/iim.c b/arch/arm/mach-imx/iim.c
> > index 207e1879c3a9..2c7ffb009097 100644
> > --- a/arch/arm/mach-imx/iim.c
> > +++ b/arch/arm/mach-imx/iim.c
> > @@ -329,9 +329,9 @@ static int imx_iim_add_bank(struct iim_priv *iim, int num, int nregs)
> >  
> >  	iim->bank[num] = bank;
> >  
> > -	bank->map_config.reg_bits = 8,
> > -	bank->map_config.val_bits = 8,
> > -	bank->map_config.reg_stride = 1,
> > +	bank->map_config.reg_bits = 8;
> > +	bank->map_config.val_bits = 8;
> > +	bank->map_config.reg_stride = 1;
> >  	bank->map_config.max_register = (nregs - 1),
> 
> Your regex didn't spot this line :)

Changed and added to this patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-05-20 12:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17 18:20 Ahmad Fatoum
2020-05-18  6:36 ` Sascha Hauer
2020-05-18  9:31 ` Roland Hieber
2020-05-20 12:05   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520120559.GE11869@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox