Re: [PATCH] pwm: Replace license and copyright boilerplate by SPDX identfiers

[Roland Hieber <rhi@pengutronix.de>]

On Sat, May 23, 2020 at 05:00:32PM +0200, Uwe Kleine-König wrote:
> Hello Sascha, hello Roland,
> 
> On Sat, May 23, 2020 at 04:16:12PM +0200, Roland Hieber wrote:
> > On Fri, May 22, 2020 at 03:17:59PM +0200, Uwe Kleine-König wrote:
> > > Hello Roland,
> > > 
> > > On Fri, May 22, 2020 at 02:55:56PM +0200, Roland Hieber wrote:
> > > > On Wed, May 20, 2020 at 02:10:47PM +0200, Ahmad Fatoum wrote:
> > > > > On 5/19/20 6:52 PM, Uwe Kleine-König wrote:
> > > > > > diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> > > > > > index a06040ac3268..1e2db39def22 100644
> > > > > > --- a/drivers/pwm/pwm-mxs.c
> > > > > > +++ b/drivers/pwm/pwm-mxs.c
> > > > > > @@ -1,13 +1,5 @@
> > > > > > -/*
> > > > > > - * Copyright 2012 Freescale Semiconductor, Inc.
> > > > > > - *
> > > > > > - * The code contained herein is licensed under the GNU General Public
> > > > > > - * License. You may obtain a copy of the GNU General Public License
> > > > > > - * Version 2 or later at the following locations:
> > > > > > - *
> > > > > > - * http://www.opensource.org/licenses/gpl-license.html
> > > > > > - * http://www.gnu.org/copyleft/gpl.html
> > > > > > - */
> > > > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > > > 
> > > > > The deleted text says "or later"
> > > > 
> > > > Ah, I stumbled over this too. The deleted text says:
> > > > 
> > > >     "The code contained herein is licensed under the GNU General Public
> > > >     License."
> > > > 
> > > > which in itself reads like "you can use any version of the GPL" (i.e.,
> > > > GPL-1.0-or-later). Later then the text says:
> > > > 
> > > >     "You may obtain a copy of the GNU General Public License
> > > >     Version 2 or later at the following locations:"
> > > > 
> > > > which in my opinion does not say anything about which version of the GPL
> > > > the code is licensed under.
> > > 
> > > This seems to be a problem in the Freescale template. I think I pointed
> > > that out once, but nothing changed.
> > > 
> > > For practical reasons I'd interpret that as "GPL-2.0-or-later".
> > 
> > Yeah, I guess that's alright.
> > 
> > Reviewed-by: Roland Hieber <rhi@pengutronix.de>
> 
> I assume this Reviewed-by: applies only if we squash
> 
> diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> index 1e2db39def22..08819b43bc1d 100644
> --- a/drivers/pwm/pwm-mxs.c
> +++ b/drivers/pwm/pwm-mxs.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0-only
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  // SPDX-FileCopyrightText: 2012 Freescale Semiconductor, Inc.
>  
>  #include <common.h>
> 
> into the patch Sascha applied.

Yes, that's what I meant too ^^

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox