From: Sascha Hauer <s.hauer@pengutronix.de>
To: David Dgien <dgienda125@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] password: Fix warning with empty default password
Date: Mon, 25 May 2020 13:10:53 +0200 [thread overview]
Message-ID: <20200525111053.GR11869@pengutronix.de> (raw)
In-Reply-To: <20200523005156.148504-1-dgienda125@gmail.com>
On Fri, May 22, 2020 at 08:51:56PM -0400, David Dgien wrote:
> When CONFIG_PASSWORD_DEFAULT is unset, the default_passwd buffer is set
> to the empty string. The read_default_passwd() function wants to read at
> least two characters from that buffer, causing GCC to generate an array
> bounds warning:
>
> barebox/common/password.c: In function 'login':
> barebox/common/password.c:173:5: warning: array subscript [1, 2147483647] is outside array bounds of 'const char[1]' [-Warray-bounds]
> In file included from barebox/common/password.c:30:
> include/generated/passwd.h:1:19: note: while referencing 'default_passwd'
>
> Add an ARRAY_SIZE check to default_passwd so that the loop is optimized
> away and the warning is no longer generated. Since the
> read_default_passwd() function is only called when default_passwd is not
> the empty string, this is not a functional change.
>
> Signed-off-by: David Dgien <dgienda125@gmail.com>
> ---
> Changes since v1:
> - Added warning output to commit message
> - Rework fix in read_default_passwd() instead of hacking with the makefile
>
> common/password.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-05-25 11:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 0:51 David Dgien
2020-05-25 11:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525111053.GR11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dgienda125@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox