From: Clement Leger <cleger@kalray.eu>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Cc: Clement Leger <cleger@kalray.eu>,
Oleksij Rempel <linux@rempel-privat.de>
Subject: [PATCH v5 1/7] common: elf: fix warning on 32 bits architectures
Date: Thu, 11 Jun 2020 10:02:01 +0200 [thread overview]
Message-ID: <20200611080207.6482-2-cleger@kalray.eu> (raw)
In-Reply-To: <20200611080207.6482-1-cleger@kalray.eu>
When pointers are 32 bits wide and we cast a potentially 64 bits
value in it, the compiler will yield an error. Cast that value first
into a phys_addr_t to match the architecture pointer size and then
in a void *.
Signed-off-by: Clement Leger <cleger@kalray.eu>
---
common/elf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/elf.c b/common/elf.c
index d64de401c..55f5bc645 100644
--- a/common/elf.c
+++ b/common/elf.c
@@ -47,7 +47,7 @@ static void elf_release_regions(struct elf_image *elf)
static int load_elf_phdr_segment(struct elf_image *elf, void *src,
void *phdr)
{
- void *dst = (void *) elf_phdr_p_paddr(elf, phdr);
+ void *dst = (void *) (phys_addr_t) elf_phdr_p_paddr(elf, phdr);
int ret;
u64 p_filesz = elf_phdr_p_filesz(elf, phdr);
u64 p_memsz = elf_phdr_p_memsz(elf, phdr);
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-06-11 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 8:02 [PATCH v5 0/7] elf: add better bootm support Clement Leger
2020-06-11 8:02 ` Clement Leger [this message]
2020-06-11 8:02 ` [PATCH v5 2/7] common: elf: use calloc instead of xzalloc Clement Leger
2020-06-11 8:02 ` [PATCH v5 3/7] common: elf: check number of elf program headers Clement Leger
2020-06-11 8:02 ` [PATCH v5 4/7] common: elf: load elf directly from file Clement Leger
2020-06-11 8:02 ` [PATCH v5 5/7] common: elf: add elf_open, elf_close and elf_load Clement Leger
2020-06-11 8:02 ` [PATCH v5 6/7] common: bootm: add support for elf file loading Clement Leger
2020-06-11 8:02 ` [PATCH v5 7/7] mips: lib: bootm: use bootm elf loading capabilities Clement Leger
2020-06-12 5:22 ` [PATCH v5 0/7] elf: add better bootm support Oleksij Rempel
2020-06-12 6:55 ` Clément Leger
2020-06-12 6:57 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611080207.6482-2-cleger@kalray.eu \
--to=cleger@kalray.eu \
--cc=barebox@lists.infradead.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox