mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 09/15] ARM: i.MX6UL: dts: remove defunct override of pico-hobbit memory node
Date: Thu, 18 Jun 2020 11:15:50 +0200	[thread overview]
Message-ID: <20200618091550.GT21325@pengutronix.de> (raw)
In-Reply-To: <20200618091102.30150-10-a.fatoum@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1844 bytes --]

On Thu, Jun 18, 2020 at 11:10:56AM +0200, Ahmad Fatoum wrote:
>Prior to 8226f7f90973 ("of: base: parse all available memory nodes"),
>barebox first looked at a /memory node, then at a node with a
>device_type = "memory" property when probing available memory banks from
>device tree. Linux instead only considered nodes with device_type =
>"memory". The imx6ul-pico-hobbit predates the change in barebox behavior,
>so it's unclear what is gained from dropping device_type = "memory" as
>barebox used to parse the node by name anyway and Linux only saw the new
>fixed up node.
>
>Since then the Linux device tree has been split into a SoM and carrier
>board device tree and the node name is now called memory@80000000 with
>a size of 0 in the reg property. Because it's already used for boards
>with differing memory size, we assume this will remain so and thus we
>just drop the defunct barebox memory node override.
>
>Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
>Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>---
> arch/arm/dts/imx6ul-pico-hobbit.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/arch/arm/dts/imx6ul-pico-hobbit.dts b/arch/arm/dts/imx6ul-pico-hobbit.dts
>index 2f37b724b6e1..0c543de8c916 100644
>--- a/arch/arm/dts/imx6ul-pico-hobbit.dts
>+++ b/arch/arm/dts/imx6ul-pico-hobbit.dts
>@@ -9,10 +9,6 @@
> 			device-path = &environment_usdhc1;
> 		};
> 	};
>-
>-	memory {
>-		/delete-property/ device_type;
>-	};
> };
>
> &usdhc1 {
>-- 
>2.27.0

Ack

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-06-18  9:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  9:10 [PATCH 00/15] ARM: dts: fix regressions from not using phandles Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 01/15] ARM: i.MX50: fix renamed node reference Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 02/15] ARM: dts: fix now duplicate memory nodes Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 03/15] ARM: dts: align all applicable memory nodes with spec and convention Ahmad Fatoum
2020-06-18 13:59   ` Sascha Hauer
2020-06-18  9:10 ` [PATCH 04/15] ARM: vexpress: dts: fix barebox partitioning breakage Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 05/15] ARM: at91: dts: extend, don't create anew, pinctrl node Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 06/15] ARM: dts: reference nodes to extend by phandles instead Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 07/15] ARM: i.MX7: warp: drop duplicate memory node Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 08/15] ARM: mvebu: remove reference to non-existant node Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 09/15] ARM: i.MX6UL: dts: remove defunct override of pico-hobbit memory node Ahmad Fatoum
2020-06-18  9:15   ` Michael Grzeschik [this message]
2020-06-18  9:10 ` [PATCH 10/15] ARM: layerscape: dts: combine fsl-ls1046a-rdb.dts aliases nodes Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 11/15] ARM: i.MX7: dts: replace commented-out code with status = "disabled" Ahmad Fatoum
2020-06-18  9:10 ` [PATCH 12/15] ARM: i.MX: mx53-qsrb: dts: remove now-superfluous override Ahmad Fatoum
2020-06-18  9:11 ` [PATCH 13/15] ARM: zynqmp: dts: drop now superfluous zynqmp.dtsi Ahmad Fatoum
2020-06-18  9:11 ` [PATCH 14/15] ARM: socfpga: dts: remove unused nodes and phandles Ahmad Fatoum
2020-06-18  9:11 ` [PATCH 15/15] Documentation: devicetree: codify extension of upstream DTS by phandles Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618091550.GT21325@pengutronix.de \
    --to=mgr@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox