From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Daniel Glöckner" <dg@emlix.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 14/19] fastboot: remove double print
Date: Fri, 19 Jun 2020 09:01:24 +0200 [thread overview]
Message-ID: <20200619070124.GP11869@pengutronix.de> (raw)
In-Reply-To: <b170eaf6-60cb-2f8f-aff0-547f4fa03f0a@emlix.com>
On Thu, Jun 18, 2020 at 09:08:01PM +0200, Daniel Glöckner wrote:
> Am 17.06.20 um 21:54 schrieb Sascha Hauer:
> > Another option would be to put calling of fastboot_download_finished()
> > into a workqueue, or just open code it as your original series did.
>
> ... now I understand that by "open code it" you are referring to calling
> net_poll!
By "open code" I meant that the functionality of
fastboot_download_finished() was duplicated in the fastboot net code,
but this was never the case. It seems my memory tricked me.
>
> I would have tried to run everything from fastboot_poll in a workqueue.
> Since worklets are not reordered, splitting fastboot_poll into two worklets
> might make sense. The worklet for calling fastboot_download_finished is
> queued when fastboot_handle_type_fastboot sets active_download to false and
> the worklet for the command execution is queued, as you implemented it, when
> a new command arrives.
I gave it a try and it was easy enough to implement, so we can drop this
patch.
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-06-19 7:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:11 [PATCH v4 00/19] Slices and fastboot over UDP Sascha Hauer
2020-06-17 8:11 ` [PATCH 01/19] Introduce slices Sascha Hauer
2020-06-17 8:11 ` [PATCH 02/19] Add workqueues Sascha Hauer
2020-06-17 18:30 ` Daniel Glöckner
2020-06-17 19:56 ` Sascha Hauer
2020-06-17 8:11 ` [PATCH 03/19] ratp: Switch to workqueues Sascha Hauer
2020-06-17 8:11 ` [PATCH 04/19] net: Add a slice to struct eth_device Sascha Hauer
2020-06-17 8:11 ` [PATCH 05/19] net: mdiobus: Add slice Sascha Hauer
2020-06-17 8:11 ` [PATCH 06/19] usb: Add a slice to usb host controllers Sascha Hauer
2020-06-17 8:11 ` [PATCH 07/19] usbnet: Add slice Sascha Hauer
2020-06-17 8:11 ` [PATCH 08/19] net: Call net_poll() in a poller Sascha Hauer
2020-06-17 8:11 ` [PATCH 09/19] net: reply to ping requests Sascha Hauer
2020-06-17 8:11 ` [PATCH 10/19] usbnet: Be more friendly in the receive path Sascha Hauer
2020-06-17 8:11 ` [PATCH 11/19] defconfigs: update renamed fastboot options Sascha Hauer
2020-06-17 8:11 ` [PATCH 12/19] globalvar: Add helper for deprecated variable names Sascha Hauer
2020-06-17 8:11 ` [PATCH 13/19] fastboot: rename usbgadget.fastboot_* variables to fastboot.* Sascha Hauer
2020-06-17 8:11 ` [PATCH 14/19] fastboot: remove double print Sascha Hauer
2020-06-17 18:24 ` Daniel Glöckner
2020-06-17 19:54 ` Sascha Hauer
2020-06-18 19:08 ` Daniel Glöckner
2020-06-19 7:01 ` Sascha Hauer [this message]
2020-06-17 8:11 ` [PATCH 15/19] fastboot net: implement fastboot over UDP Sascha Hauer
2020-06-17 19:32 ` Daniel Glöckner
2020-06-18 11:59 ` Sascha Hauer
2020-06-18 18:33 ` Daniel Glöckner
2020-06-19 7:38 ` Sascha Hauer
2020-06-17 8:11 ` [PATCH 16/19] usb: fastboot: execute commands in command context Sascha Hauer
2020-06-17 19:40 ` Daniel Glöckner
2020-06-18 7:26 ` Sascha Hauer
2020-06-17 8:11 ` [PATCH 17/19] Add WARN_ONCE() macro Sascha Hauer
2020-06-17 8:11 ` [PATCH 18/19] fs: Warn when filesystem operations are called from a poller Sascha Hauer
2020-06-17 8:11 ` [PATCH 19/19] Documentation: Add document for parallel execution in barebox Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619070124.GP11869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dg@emlix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox