Re: [PATCH] arch/arm/boards: Replace license and copyright boilerplate by SPDX identfiers

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2792 bytes --]

Hello Andrey,

On Tue, May 19, 2020 at 09:49:36PM +0200, Uwe Kleine-König wrote:
> On Tue, May 19, 2020 at 06:37:33PM +0200, Uwe Kleine-König wrote:
> > This adapts all files that were identifed by licensecheck
> > (https://salsa.debian.org/build-common-team/licensecheck.git) as
> > licensed under the GPL.
> > 
> > The advantage is that these specifiers are machine-parseable which helps
> > license conformance, e.g. for packaging barebox in Debian.
> > 
> > While touching these files also do some minor comment reformatting to
> > get some uniform layout.
> 
> While going once more through this patch I noticed that there are a few
> hunks that might be questionable and it would be great if you could
> comment:
> 
> > diff --git a/arch/arm/boards/freescale-mx7-sabresd/board.c b/arch/arm/boards/freescale-mx7-sabresd/board.c
> > index 37941efdbeb4..e41d67017fe5 100644
> > --- a/arch/arm/boards/freescale-mx7-sabresd/board.c
> > +++ b/arch/arm/boards/freescale-mx7-sabresd/board.c
> > @@ -1,17 +1,7 @@
> > -/*
> > - * Copyright (C) 2017 Zodiac Inflight Innovation
> > - * Author: Andrey Smirnov <andrew.smirnov@gmail.com>
> > - *
> > - * This program is free software; you can redistribute it and/or
> > - * modify it under the terms of the GNU General Public License as
> > - * published by the Free Software Foundation; either version 2 of
> > - * the License, or (at your option) any later version.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > - * GNU General Public License for more details.
> > - */
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +// SPDX-FileCopyrightText: 2017 Zodiac Inflight Innovation
> > +
> > +/* Author: Andrey Smirnov <andrew.smirnov@gmail.com> */
> >  
> >  #include <common.h>
> >  #include <init.h>
> 
> Is this right? I.e does Zodiac hold the copyright and you are "only" the
> author? Or would
> 
> 	// SPDX-FileCopyrightText: 2017 Andrey Smirnov <andrew.smirnov@gmail.com>, Zodiac Inflight Innovation
> 
> be more appropriate?
> 
> Same question for
> 
> 	arch/arm/boards/zii-imx6q-rdu2/board.c
> 	arch/arm/boards/zii-imx6q-rdu2/lowlevel.c
> 	arch/arm/boards/zii-vf610-dev/board.c
> 	arch/arm/boards/zii-vf610-dev/lowlevel.c

While going further through the barebox source tree there are more files
with this info. Last I found was

	arch/arm/cpu/no-mmu.c

Would be really great to get some input from you on this.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox