* [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop
@ 2020-07-02 13:29 Ahmad Fatoum
2020-07-02 13:29 ` [PATCH 2/2] mfd: superio: depend on X86 || COMPILE_TEST Ahmad Fatoum
2020-07-05 14:21 ` [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2020-07-02 13:29 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Codebase is meant to be gnu89, but was only enforced starting
with bc4840e98b94 ("kbuild: add -Wmissing-prototypes and -std=gnu89
to KBUILD_HOSTCFLAGS"). Since then, this driver no longer compiles.
Fix this.
Fixes: eaf020f1bb52 ("mfd: superio: add base SMSC MFD driver")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/mfd/smsc-superio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/smsc-superio.c b/drivers/mfd/smsc-superio.c
index 349c878cefe0..ff83aa1a4419 100644
--- a/drivers/mfd/smsc-superio.c
+++ b/drivers/mfd/smsc-superio.c
@@ -106,8 +106,9 @@ static void smsc_superio_find(u16 sioaddr, u16 id_reg)
static int smsc_superio_detect(void)
{
u16 ports[] = { 0x2e, 0x4e, 0x162e, 0x164e, 0x3f0, 0x370 };
+ int i;
- for (int i = 0; i < ARRAY_SIZE(ports); i++)
+ for (i = 0; i < ARRAY_SIZE(ports); i++)
smsc_superio_find(ports[i], SIO_REG_DEVID);
return 0;
--
2.27.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] mfd: superio: depend on X86 || COMPILE_TEST
2020-07-02 13:29 [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop Ahmad Fatoum
@ 2020-07-02 13:29 ` Ahmad Fatoum
2020-07-05 14:21 ` [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2020-07-02 13:29 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Super I/O chips are usually found x86 PCs. Make them depend on it,
so users of other arches aren't prompted for it, when they oldconfig.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/mfd/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 42346154e63a..d03d481898d8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -73,12 +73,14 @@ config MFD_SUPERIO
config FINTEK_SUPERIO
bool "Fintek Super I/O chip"
select MFD_SUPERIO
+ depends on X86 || COMPILE_TEST
help
Select this to probe for IO-port connected Fintek Super I/O chips.
config SMSC_SUPERIO
bool "SMSC Super I/O chip"
select MFD_SUPERIO
+ depends on X86 || COMPILE_TEST
help
Select this to probe for IO-port connected SMSC Super I/O chips.
--
2.27.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop
2020-07-02 13:29 [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop Ahmad Fatoum
2020-07-02 13:29 ` [PATCH 2/2] mfd: superio: depend on X86 || COMPILE_TEST Ahmad Fatoum
@ 2020-07-05 14:21 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2020-07-05 14:21 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Thu, Jul 02, 2020 at 03:29:18PM +0200, Ahmad Fatoum wrote:
> Codebase is meant to be gnu89, but was only enforced starting
> with bc4840e98b94 ("kbuild: add -Wmissing-prototypes and -std=gnu89
> to KBUILD_HOSTCFLAGS"). Since then, this driver no longer compiles.
> Fix this.
>
> Fixes: eaf020f1bb52 ("mfd: superio: add base SMSC MFD driver")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/mfd/smsc-superio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mfd/smsc-superio.c b/drivers/mfd/smsc-superio.c
> index 349c878cefe0..ff83aa1a4419 100644
> --- a/drivers/mfd/smsc-superio.c
> +++ b/drivers/mfd/smsc-superio.c
> @@ -106,8 +106,9 @@ static void smsc_superio_find(u16 sioaddr, u16 id_reg)
> static int smsc_superio_detect(void)
> {
> u16 ports[] = { 0x2e, 0x4e, 0x162e, 0x164e, 0x3f0, 0x370 };
> + int i;
>
> - for (int i = 0; i < ARRAY_SIZE(ports); i++)
> + for (i = 0; i < ARRAY_SIZE(ports); i++)
> smsc_superio_find(ports[i], SIO_REG_DEVID);
>
> return 0;
> --
> 2.27.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 13:29 [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop Ahmad Fatoum
2020-07-02 13:29 ` [PATCH 2/2] mfd: superio: depend on X86 || COMPILE_TEST Ahmad Fatoum
2020-07-05 14:21 ` [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox