mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fixup! fs: Add destroy_inode callbacks to filesystems
@ 2020-07-02 14:12 Ahmad Fatoum
  2020-07-05 14:17 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2020-07-02 14:12 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

struct squashfs_inode_info *node is the pointer returned by xzalloc and
thus is what should be freed.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/squashfs/squashfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/squashfs/squashfs.c b/fs/squashfs/squashfs.c
index cb2d936ea4d8..69451f7b846b 100644
--- a/fs/squashfs/squashfs.c
+++ b/fs/squashfs/squashfs.c
@@ -80,7 +80,7 @@ static void squashfs_destroy_inode(struct inode *inode)
 {
 	struct squashfs_inode_info *node = squashfs_i(inode);
 
-	free(inode);
+	free(node);
 }
 
 static const struct super_operations squashfs_super_ops = {
-- 
2.27.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fixup! fs: Add destroy_inode callbacks to filesystems
  2020-07-02 14:12 [PATCH] fixup! fs: Add destroy_inode callbacks to filesystems Ahmad Fatoum
@ 2020-07-05 14:17 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-07-05 14:17 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Thu, Jul 02, 2020 at 04:12:32PM +0200, Ahmad Fatoum wrote:
> struct squashfs_inode_info *node is the pointer returned by xzalloc and
> thus is what should be freed.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/squashfs/squashfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/squashfs/squashfs.c b/fs/squashfs/squashfs.c
> index cb2d936ea4d8..69451f7b846b 100644
> --- a/fs/squashfs/squashfs.c
> +++ b/fs/squashfs/squashfs.c
> @@ -80,7 +80,7 @@ static void squashfs_destroy_inode(struct inode *inode)
>  {
>  	struct squashfs_inode_info *node = squashfs_i(inode);
>  
> -	free(inode);
> +	free(node);
>  }
>  
>  static const struct super_operations squashfs_super_ops = {
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-05 14:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 14:12 [PATCH] fixup! fs: Add destroy_inode callbacks to filesystems Ahmad Fatoum
2020-07-05 14:17 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox