[PATCH] fixup! fs: ramfs: Use dynamically sized chunks

[PATCH] fixup! fs: ramfs: Use dynamically sized chunks

[Ahmad Fatoum]

typeof(insize) is size_t and typeof(pos) is unsigned long.
Use the appropriate format length modifiers.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ramfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 84aa56f83ec6..14ba87766098 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -230,14 +230,14 @@ static int ramfs_read(struct device_d *_dev, FILE *f, void *buf, size_t insize)
 	unsigned long pos = f->pos;
 	int size = insize;
 
-	debug("%s: %p %d @ %lld\n", __func__, node, insize, f->pos);
+	debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
 
 	while (size) {
 		data = ramfs_find_chunk(node, pos, &ofs, &len);
 		if (!data)
 			return -EINVAL;
 
-		debug("%s: pos: %ld ofs: %d len: %d\n", __func__, pos, ofs, len);
+		debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
 
 		now = min(size, len);
 
@@ -260,14 +260,14 @@ static int ramfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t i
 	unsigned long pos = f->pos;
 	int size = insize;
 
-	debug("%s: %p %d @ %lld\n", __func__, node, insize, f->pos);
+	debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
 
 	while (size) {
 		data = ramfs_find_chunk(node, pos, &ofs, &len);
 		if (!data)
 			return -EINVAL;
 
-		debug("%s: pos: %ld ofs: %d len: %d\n", __func__, pos, ofs, len);
+		debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
 
 		now = min(size, len);
 
-- 
2.27.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! fs: ramfs: Use dynamically sized chunks

[Sascha Hauer]

On Thu, Jul 02, 2020 at 04:24:33PM +0200, Ahmad Fatoum wrote:
> typeof(insize) is size_t and typeof(pos) is unsigned long.
> Use the appropriate format length modifiers.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/ramfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/ramfs.c b/fs/ramfs.c
> index 84aa56f83ec6..14ba87766098 100644
> --- a/fs/ramfs.c
> +++ b/fs/ramfs.c
> @@ -230,14 +230,14 @@ static int ramfs_read(struct device_d *_dev, FILE *f, void *buf, size_t insize)
>  	unsigned long pos = f->pos;
>  	int size = insize;
>  
> -	debug("%s: %p %d @ %lld\n", __func__, node, insize, f->pos);
> +	debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
>  
>  	while (size) {
>  		data = ramfs_find_chunk(node, pos, &ofs, &len);
>  		if (!data)
>  			return -EINVAL;
>  
> -		debug("%s: pos: %ld ofs: %d len: %d\n", __func__, pos, ofs, len);
> +		debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
>  
>  		now = min(size, len);
>  
> @@ -260,14 +260,14 @@ static int ramfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t i
>  	unsigned long pos = f->pos;
>  	int size = insize;
>  
> -	debug("%s: %p %d @ %lld\n", __func__, node, insize, f->pos);
> +	debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
>  
>  	while (size) {
>  		data = ramfs_find_chunk(node, pos, &ofs, &len);
>  		if (!data)
>  			return -EINVAL;
>  
> -		debug("%s: pos: %ld ofs: %d len: %d\n", __func__, pos, ofs, len);
> +		debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
>  
>  		now = min(size, len);
>  
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox