Re: [PATCH 2/2] arm/cpu: Replace license and copyright boilerplate by SPDX identfiers

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 3704 bytes --]

Hello Ahmad,

On Thu, Jul 02, 2020 at 10:23:16AM +0200, Ahmad Fatoum wrote:
> On 7/1/20 10:11 PM, Uwe Kleine-König wrote:
> > diff --git a/arch/arm/cpu/interrupts.c b/arch/arm/cpu/interrupts.c
> > index 703a5a3ba706..a1728eb353c8 100644
> > --- a/arch/arm/cpu/interrupts.c
> > +++ b/arch/arm/cpu/interrupts.c
> > @@ -1,18 +1,5 @@
> > -/*
> > - * interrupts.c - Interrupt Support Routines
> 
> I don't care much either way, but in the other files you moved this header
> line into a new comment block, here it's deleted.

I deleted this one because the file continues with:

/**
 * @file
 * @brief Interrupt Support Routines
 */

> > - *
> > - * Copyright (c) 2007 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2
> > - * as published by the Free Software Foundation.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > - * GNU General Public License for more details.
> > - *
> > - */
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +// SPDX-FileCopyrightText: 2007 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> >  
> >  /**
> >   * @file
> > [...]
> > diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c
> > index 2aa53229b323..1e42ec63c0ef 100644
> > --- a/arch/arm/cpu/mmu.c
> > +++ b/arch/arm/cpu/mmu.c
> > @@ -1,16 +1,5 @@
> > -/*
> > - * Copyright (c) 2009-2013 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2
> > - * as published by the Free Software Foundation.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > - * GNU General Public License for more details.
> > - *
> > - */
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +// SPDX-FileCopyrightText: /* 2009-2013 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> 
> Remove the /*

Oh, indeed.

> >  #define pr_fmt(fmt)	"mmu: " fmt
> >  
> > diff --git a/arch/arm/cpu/mmu_64.c b/arch/arm/cpu/mmu_64.c
> > index 8324cedb25ad..ee4543b3c074 100644
> > --- a/arch/arm/cpu/mmu_64.c
> > +++ b/arch/arm/cpu/mmu_64.c
> > @@ -1,17 +1,6 @@
> > -/*
> > - * Copyright (c) 2009-2013 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> > - * Copyright (c) 2016 Raphaël Poggi <poggi.raph@gmail.com>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2
> > - * as published by the Free Software Foundation.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > - * GNU General Public License for more details.
> > - *
> > - */
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +// SPDX-FileCopyrightText: 009-2013 Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
> 
> s/009/2009/

huh.

thanks for your review, will send a v2.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox