mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! fs: ramfs: Use dynamically sized chunks
Date: Sun, 5 Jul 2020 16:15:21 +0200	[thread overview]
Message-ID: <20200705141521.GR15485@pengutronix.de> (raw)
In-Reply-To: <20200702142433.10914-1-a.fatoum@pengutronix.de>

On Thu, Jul 02, 2020 at 04:24:33PM +0200, Ahmad Fatoum wrote:
> typeof(insize) is size_t and typeof(pos) is unsigned long.
> Use the appropriate format length modifiers.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/ramfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/ramfs.c b/fs/ramfs.c
> index 84aa56f83ec6..14ba87766098 100644
> --- a/fs/ramfs.c
> +++ b/fs/ramfs.c
> @@ -230,14 +230,14 @@ static int ramfs_read(struct device_d *_dev, FILE *f, void *buf, size_t insize)
>  	unsigned long pos = f->pos;
>  	int size = insize;
>  
> -	debug("%s: %p %d @ %lld\n", __func__, node, insize, f->pos);
> +	debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
>  
>  	while (size) {
>  		data = ramfs_find_chunk(node, pos, &ofs, &len);
>  		if (!data)
>  			return -EINVAL;
>  
> -		debug("%s: pos: %ld ofs: %d len: %d\n", __func__, pos, ofs, len);
> +		debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
>  
>  		now = min(size, len);
>  
> @@ -260,14 +260,14 @@ static int ramfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t i
>  	unsigned long pos = f->pos;
>  	int size = insize;
>  
> -	debug("%s: %p %d @ %lld\n", __func__, node, insize, f->pos);
> +	debug("%s: %p %zu @ %lld\n", __func__, node, insize, f->pos);
>  
>  	while (size) {
>  		data = ramfs_find_chunk(node, pos, &ofs, &len);
>  		if (!data)
>  			return -EINVAL;
>  
> -		debug("%s: pos: %ld ofs: %d len: %d\n", __func__, pos, ofs, len);
> +		debug("%s: pos: %lu ofs: %d len: %d\n", __func__, pos, ofs, len);
>  
>  		now = min(size, len);
>  
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-07-05 14:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 14:24 Ahmad Fatoum
2020-07-05 14:15 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705141521.GR15485@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox