From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtXMY-0000lC-Ro for barebox@lists.infradead.org; Thu, 09 Jul 2020 14:17:23 +0000 Date: Thu, 9 Jul 2020 16:17:21 +0200 From: Sascha Hauer Message-ID: <20200709141721.GD15485@pengutronix.de> References: <20200702085934.5827-1-a.fatoum@pengutronix.de> <20200705173513.GX15485@pengutronix.de> <6be7e02f-a8a6-e76f-9960-ccff916bcf54@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6be7e02f-a8a6-e76f-9960-ccff916bcf54@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] kbuild: add dtbs target for building all dtbs of an ARCH To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Mon, Jul 06, 2020 at 12:31:09AM +0200, Ahmad Fatoum wrote: > > > On 7/5/20 7:35 PM, Sascha Hauer wrote: > > On Thu, Jul 02, 2020 at 10:59:34AM +0200, Ahmad Fatoum wrote: > >> As described in the documentation, upstream device trees extended by > >> barebox should take care to cause compile errors, not runtime errors, > >> when the paths they extend disappear. This way, breakage can be easily > >> detected when synchronizing the dts/ directory and fixed right then. > >> > >> Make this process easier by providing a dtbs target that builds all > >> device trees in arch/$(SRCARCH)/dts/ if available. > >> > >> Signed-off-by: Ahmad Fatoum > >> --- > >> Makefile | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >> diff --git a/Makefile b/Makefile > >> index 0da032532712..9fa741966c00 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -990,6 +990,20 @@ include/generated/version.h: FORCE > >> include/generated/utsrelease.h: include/config/kernel.release FORCE > >> $(call filechk,utsrelease.h) > >> > >> +# --------------------------------------------------------------------------- > >> +# Devicetree files > >> + > >> +ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/dts/),) > >> +dtstree := arch/$(SRCARCH)/dts > >> +endif > >> + > >> +ifneq ($(dtstree),) > >> + > >> +PHONY += dtbs > >> +dtbs: $(patsubst $(srctree)/%.dts,$(objtree)/%.dtb,$(wildcard $(srctree)/$(dtstree)/*.dts)) > >> + > >> +endif > > > > Can we do this in a way that only rebuilds the changed files and not > > every dts again? > > Probably, I would have to check how though. But it doesn't matter that much IMO. > Target is meant to be run only after dts/ update. It's not part of the normal > development workflow. Well, you could convince me that this is really hard to solve, then we can talk about merging it like this. Otherwise I would really prefer solving this proper. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox