From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] sandbox: include: <asm/types.h>: don't define INTERNAL_SIZE_T
Date: Sat, 11 Jul 2020 06:34:04 +0200 [thread overview]
Message-ID: <20200711043404.GM15485@pengutronix.de> (raw)
In-Reply-To: <20200706062805.26278-1-a.fatoum@pengutronix.de>
On Mon, Jul 06, 2020 at 08:28:03AM +0200, Ahmad Fatoum wrote:
> The INTERNAL_SIZE_T default is size_t, which already is 64-bit on 64-bit
> platforms and 32-bit on 32-bit ones. We can thus drop the #define and go
> back to the minimal <asm/types.h>.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> arch/sandbox/include/asm/types.h | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/sandbox/include/asm/types.h b/arch/sandbox/include/asm/types.h
> index 28046670f4e2..7b356a99eb66 100644
> --- a/arch/sandbox/include/asm/types.h
> +++ b/arch/sandbox/include/asm/types.h
> @@ -1,15 +1,6 @@
> -#ifndef __ASM_I386_TYPES_H
> -#define __ASM_I386_TYPES_H
> +#ifndef __ASM_SANDBOX_TYPES_H
> +#define __ASM_SANDBOX_TYPES_H
>
> #include <asm-generic/int-ll64.h>
>
> -#ifdef __x86_64__
> -/*
> - * This is used in dlmalloc. On X86_64 we need it to be
> - * 64 bit
> - */
> -#define INTERNAL_SIZE_T unsigned long
> -
> -#endif
> -
> #endif
> --
> 2.27.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-07-11 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 6:28 Ahmad Fatoum
2020-07-06 6:28 ` [PATCH 2/4] sandbox: os: common: fix compiler warning in add_image() Ahmad Fatoum
2020-07-06 6:28 ` [PATCH 3/4] sandbox: add libc memory allocator Ahmad Fatoum
2020-07-06 6:28 ` [PATCH 4/4] sandbox: reinstate cooked terminal mode on sanitizer-induced death Ahmad Fatoum
2020-07-11 4:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711043404.GM15485@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox