From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org, david@protonic.nl
Subject: Re: [PATCH v3 1/3] devinfo: do not dump the device node for the root node
Date: Fri, 17 Jul 2020 06:11:10 +0200 [thread overview]
Message-ID: <20200717041110.qih33m4en77omhwq@pengutronix.de> (raw)
In-Reply-To: <1159851c97f3fff37c5ec0e2cb005007d1903b85.camel@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1763 bytes --]
On Thu, Jul 16, 2020 at 11:40:46AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 16.07.2020, 08:46 +0200 schrieb Oleksij Rempel:
> > Calling the devinfo against a device which is linked to some devicetree
> > node weill result a devictree dump of this node. For example:
> >
> > barebox@Protonic PRTI6Q board:/ devinfo sound-spdif.of
> > Bus: platform
> > Device node: /sound-spdif
> > sound-spdif {
> > compatible = "fsl,imx-audio-spdif";
> > model = "imx-spdif";
> > spdif-controller = <0x7a>;
> > spdif-in;
> > spdif-out;
> > };
> >
> > Calling same command on a device wich is linked to the root node of
> > devicetree, for example "machine.of", will trigger a dump fo complete
> > devicetree.
>
> Taking a step back from the immediate issue with the root node: is it
> even a good idea to dump the whole subtree of nodes in the devinfo?
> Most likely someone using devinfo is only interested in the of_node of
> the device and maybe some subnodes that don't have a device on their
> own.
>
> So wouldn't it make more sense to only dump the node of the device in
> question and subnodes without a compatible? This way we could remove
> the special case for the root node and still get some useful
> information in devinfo, like the board compatible property.
Hm... i have nothing against it. Then probably it is better to exclude
this patch for now.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-17 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 6:46 [PATCH v2 0/3] introduce board-driver support Oleksij Rempel
2020-07-16 6:46 ` [PATCH v3 1/3] devinfo: do not dump the device node for the root node Oleksij Rempel
2020-07-16 9:40 ` Lucas Stach
2020-07-17 4:11 ` Oleksij Rempel [this message]
2020-07-16 6:46 ` [PATCH v3 2/3] of: base: register DT root as device Oleksij Rempel
2020-07-16 6:46 ` [PATCH v3 3/3] ARM: embest-riotboard: port board file to the driver model Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717041110.qih33m4en77omhwq@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=david@protonic.nl \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox