From: Anees Rehman <anees.r3hman@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Anees Rehman <anees.rehman@atlascopco.com>, barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: i.MX: Add atlascopco sxb board
Date: Mon, 10 Aug 2020 10:31:15 +0200 [thread overview]
Message-ID: <20200810083115.GA614969@man-ws> (raw)
In-Reply-To: <20200806124127.iw4k32vpzrdb6f42@pengutronix.de>
On Thu, Aug 06, 2020 at 02:41:27PM +0200, Marco Felsch wrote:
> On 20-08-04 23:41, Anees Rehman wrote:
>
> ...
>
> > +static noinline void imx7d_sxb_sram_setup(void)
> > +{
> > + int ret;
> > +
> > + relocate_to_current_adr();
> > + setup_c();
> > +
> > + pr_debug("configuring ddr...\n");
> > + write_regs(imx7d_ixb_dcd, ARRAY_SIZE(imx7d_ixb_dcd));
> > +
> > + ret = imx7_esdhc_start_image(2);
> > +
> > + BUG_ON(ret);
> > +}
> > +
> > +ENTRY_FUNCTION(start_ac_sxb, r0, r1, r2)
> > +{
> > + imx7_cpu_lowlevel_init();
> > +
> > + if (IS_ENABLED(CONFIG_DEBUG_LL))
> > + setup_uart();
> > +
> > + if (get_pc() < 0x80000000)
> > + imx7d_sxb_sram_setup();
>
> Nit:
> After this call we are running in the correct place...
>
> > + imx7d_barebox_entry(__dtb_z_ac_sxb_start + get_runtime_offset());
>
> So get_runtime_offset() shouldn't be necessary if I got it right.
>
> > +}
If I remove get_runtime_offset(), I end up with the
following crash:
initcall-> imx_init+0x1/0x238
detected i.MX7d revision 1.2
i.MX reset reason POR (SRSR: 0x00000001)
initcall imx_init+0x1/0x238 failed: Invalid argument
initcall-> imx_serial_driver_register+0x1/0xc
initcall-> input_init+0x1/0x70
initcall-> dos_partition_init+0x1/0xc
initcall-> efi_partition_init+0x1/0xc
initcall-> imx_esdctl_init+0x1/0xc
initcall-> mmu_init+0x1/0x34
MMU: No memory bank found! Cannot continue
[<9fe6373d>] (unwind_backtrace+0x1/0x78) from [<9fe01379>] (panic+0x1d/0x34)
[<9fe01379>] (panic+0x1d/0x34) from [<9fe614b9>] (mmu_init+0x19/0x34)
[<9fe614b9>] (mmu_init+0x19/0x34) from [<9fe01061>] (start_barebox+0x51/0x90)
[<9fe01061>] (start_barebox+0x51/0x90) from [<9fe61749>] (barebox_non_pbl_start+0x121/0x164)
[<9fe61749>] (barebox_non_pbl_start+0x121/0x164) from [<9fe00005>] (__bare_init_start+0x1/0xc)
### ERROR ### Please RESET the board ###
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-08-10 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 21:41 [PATCH v2 0/2] ARM: i.MX: Add support for IMX7 based board Anees Rehman
2020-08-04 21:41 ` [PATCH v2 1/2] mci: imx-esdhc-pbl: Add support for IMX7 Anees Rehman
2020-08-04 21:41 ` [PATCH v2 2/2] ARM: i.MX: Add atlascopco sxb board Anees Rehman
2020-08-06 12:41 ` Marco Felsch
2020-08-10 8:31 ` Anees Rehman [this message]
2020-08-10 9:01 ` Marco Felsch
2020-08-10 9:33 ` [PATCH v2 0/2] ARM: i.MX: Add support for IMX7 based board Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810083115.GA614969@man-ws \
--to=anees.r3hman@gmail.com \
--cc=anees.rehman@atlascopco.com \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox