From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Barebox List <barebox@lists.infradead.org>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] treewide: remove stale instances of struct device
Date: Mon, 10 Aug 2020 21:30:22 +0200 [thread overview]
Message-ID: <20200810193022.GC31536@pengutronix.de> (raw)
In-Reply-To: <CAK7LNAT_00x3qCRiU8J_K=MHD-=cFZUmHGxxoTXx2md+=0gO-g@mail.gmail.com>
On Tue, Aug 04, 2020 at 02:02:16PM +0900, Masahiro Yamada wrote:
> On Tue, Aug 4, 2020 at 6:22 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > On Tue, Jul 21, 2020 at 08:15:23AM +0200, Ahmad Fatoum wrote:
> > > We call it struct device_d, any instances of struct device are likely
> > > left-over code after porting from Linux.
> > >
> > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > > ---
> > > drivers/crypto/caam/intern.h | 5 -----
> > > drivers/crypto/caam/jr.h | 2 --
> > > drivers/gpio/gpio-sx150x.c | 1 -
> > > drivers/usb/musb/musb_gadget.c | 9 ---------
> > > 4 files changed, 17 deletions(-)
> >
> > Applied, thanks
> >
> > Sascha
>
>
> Why doesn't barebox use (struct device)?
For historical reasons. When creating barebox I thought that it's better
to not use the same struct name when they are not exactly compatible. We
have struct driver_d for the same reason.
I am not sure I would do the same again. If we find good reasons to name
them struct device and struct driver we can change that.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-08-10 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 6:15 Ahmad Fatoum
2020-08-03 21:21 ` Sascha Hauer
2020-08-04 5:02 ` Masahiro Yamada
2020-08-10 19:30 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810193022.GC31536@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox