mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org, david@protonic.nl
Subject: Re: [PATCH v1 11/11] ARM: dts: imx6q-prti6q: add barebox.serial node
Date: Tue, 11 Aug 2020 10:27:36 +0200	[thread overview]
Message-ID: <20200811082736.GC17014@pengutronix.de> (raw)
In-Reply-To: <20200804054829.44eqvc47p5q67jam@pengutronix.de>

On Tue, Aug 04, 2020 at 07:48:29AM +0200, Oleksij Rempel wrote:
> On Mon, Aug 03, 2020 at 11:12:59PM +0200, Sascha Hauer wrote:
> > On Thu, Jul 23, 2020 at 12:33:26PM +0200, Oleksij Rempel wrote:
> > > Add serial node provider
> > > 
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > >  arch/arm/dts/imx6q-prti6q.dts | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/dts/imx6q-prti6q.dts b/arch/arm/dts/imx6q-prti6q.dts
> > > index 76bb4d53d3..67e7f63979 100644
> > > --- a/arch/arm/dts/imx6q-prti6q.dts
> > > +++ b/arch/arm/dts/imx6q-prti6q.dts
> > > @@ -18,6 +18,11 @@
> > >  			compatible = "barebox,environment";
> > >  			device-path = &ecspi1, "partname:env";
> > >  		};
> > > +		serial {
> > > +			compatible = "barebox,serial";
> > > +			nvmem-cell-names = "serial-number";
> > > +			/* nvmem-cells will added board code */
> > 
> > You probably mean "nvmem-cells will be added by board code".
> > 
> > You need board code to fully describe the device which triggers a
> > freshly written driver which puts the found serial number as
> > /serial-number into dt. Is this really worth it? I'd just read the
> > serial number in board code and put it into dt, maybe add some helper
> > function to set the right property from a given string.
> 
> If eeprom should only be used to read serial-number - yes. But this
> RFID-eeprom provides more space and functionality. Why not make it
> available for barebox and linux to be able to do more things with it?

Yes, the EEPROM should be available to Linux and barebox, I do not
disagree here. I was referring to the way you extract the serial number
here. You already have the information where the serial number is in
board code. So instead of putting it into the device tree where some
driver picks it up you could use that information directly.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-08-11  8:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 10:33 [PATCH v1 00/11] prepare Protonic board code for mainline Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 01/11] ARM: dts: imx6q-prti6q: fix PHY register Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 02/11] of: base: register DT root as device Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 03/11] ARM: embest-riotboard: port board file to the driver model Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 04/11] net: port nvmem_get_mac_address() from linux kernel Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 05/11] of: of_net: sync of_get_mac_address() with latest kernel version Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 06/11] net: fec_imx: use of_get_mac_address() to get mac address out of DT Oleksij Rempel
2020-08-03 20:13   ` Sascha Hauer
2020-08-04  5:29     ` Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 07/11] of: of_device_get_match_compatible() helper Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 08/11] gpiolib: add gpio_array_to_id helper to get ID out of GPIO array Oleksij Rempel
2020-08-03 20:22   ` Sascha Hauer
2020-08-04  5:22     ` Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 09/11] ARM: protonic-imx6: port protonic specific board code Oleksij Rempel
2020-08-03 20:49   ` Sascha Hauer
2020-08-04  6:22     ` Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 10/11] of: add barebox-serial driver Oleksij Rempel
2020-07-23 10:33 ` [PATCH v1 11/11] ARM: dts: imx6q-prti6q: add barebox.serial node Oleksij Rempel
2020-08-03 21:12   ` Sascha Hauer
2020-08-04  5:48     ` Oleksij Rempel
2020-08-11  8:27       ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811082736.GC17014@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=david@protonic.nl \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox