From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH fixup v1] of: base: register DT root as device
Date: Wed, 12 Aug 2020 18:11:09 +0200 [thread overview]
Message-ID: <20200812161109.66jgmksevsru3w5c@pengutronix.de> (raw)
In-Reply-To: <b2c40e80-946d-ede0-97b2-b0a1d4dccace@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 2865 bytes --]
On Wed, Aug 12, 2020 at 05:37:33PM +0200, Ahmad Fatoum wrote:
> Hello,
>
> On 8/12/20 5:13 PM, Oleksij Rempel wrote:
> >>> + dev_set_name(dev, "dt-root.of");
> >>
> >> Couldn't we drop the dt-? just let it be root.of.
> >> dashes make use of device parameters less convenient should we
> >> want to use those in future IIRC.
> >
> > dt is used to make clear: it is root of dt and not some random root of
> > what ever.
>
> It's redundant, there is already a .of suffix.
> I like machine.of more though.
>
> >> of_platform_device_create does:
> >>
> >> [-] check if device is available: not applicable to root node
> >> [-] populate io resources: not applicable to root node
> >> [-] use of_device_make_bus_id to get a name: not applicable to root node (prior to this patch)
> >> [-] configure dma: not applicable to root node
> >> [x] call platform_device_register
> >
> > You make this assumption, just because this node has no parents?
> > Does it means, a parent less child may have no resources to do some work?
> > You should be ashamed of yourself! :D
> >
> > But really, what prevents you to assign board specific resource to a
> > root node. It is just node as many others.
>
> It makes no sense for the root node to have resources.
> What is a machine-wide interrupt? Or a machine-wide MMIO region?
> What size would that region even have, when you have no parent
> bus that defines address/size cells?
yes, you are right.
> Do you have any examples of oftree resources for the root node?
Do you have any example of the root node used as device?
> I'd rather not litter core code with an if-clause that evaluates to
> true only once,
How many ifs are added in this patch and how many ifs will by added by
your suggestion?
> to support your (IMHO wrong) use of a helper.
Interesting change of conversation. Please stay technical.
> of_device_make_bus_id is taken from Linux and does per comment:
>
> This routine will first try using the translated bus address to
> derive a unique name. If it cannot, then it will prepend names from
> parent nodes until a unique name can be derived.
>
> IMO, it should stay that way.
Ok, i'll send a patch to rename of_device_make_bus_id to of_device_make_id.
In this case it will reflect new reality and keep the code readable.
If you have arguments in following topics:
- it will significantly affect performance
- it will affect size of executable
- it will affect maintainability
Please use them
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-08-12 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 8:55 Oleksij Rempel
2020-08-12 9:42 ` Sascha Hauer
2020-08-12 12:40 ` Ahmad Fatoum
2020-08-12 13:08 ` Ahmad Fatoum
2020-08-12 15:13 ` Oleksij Rempel
2020-08-12 15:37 ` Ahmad Fatoum
2020-08-12 16:11 ` Oleksij Rempel [this message]
2020-08-12 18:15 ` Ahmad Fatoum
2020-08-12 18:24 ` Lucas Stach
2020-08-13 4:45 ` Oleksij Rempel
2020-08-17 4:45 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812161109.66jgmksevsru3w5c@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox