From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH fixup v1] of: base: register DT root as device
Date: Mon, 17 Aug 2020 06:45:35 +0200 [thread overview]
Message-ID: <20200817044535.GC19745@pengutronix.de> (raw)
In-Reply-To: <20200812085552.12688-1-o.rempel@pengutronix.de>
On Wed, Aug 12, 2020 at 10:55:52AM +0200, Oleksij Rempel wrote:
> A usual board file contains at least one of_machine_is_compatible().
> Some of the have a rather long list with complicated version logic.
>
> To avoid own implementation for driver management, register the root node
> of device tree as platform device. So, the main platform bus can attach
> proper board driver. After this patch a typical board.c file can reuse
> existing driver infrastructure.
>
> After this patch, you will be able to see all registered board drivers
> with drvinfo as fallow:
> ...
> board-embest-riot
> board-protonic-imx6
> dt-root.of
> ...
>
> With devinfo, you'll be able to get some board specific information,
> if this is implemented:
> barebox@Protonic PRTI6Q board:/ devinfo dt-root.of
> Driver: board-protonic-imx6
> Bus: platform
> Parameters:
> boardid: 0 (type: uint32)
> boardrev: 1 (type: uint32)
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/of/base.c | 2 ++
> drivers/of/platform.c | 5 +++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 4c633bcd49..6f6cdc9379 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -2149,6 +2149,8 @@ int of_probe(void)
> if (firmware)
> of_platform_populate(firmware, NULL, NULL);
>
> + of_platform_device_create(root_node, NULL);
I am with Ahmad here: The bulk of of_platform_device_create() is unused
when called with the root node...
> +
> of_clk_init(root_node, NULL);
> of_platform_populate(root_node, of_default_bus_match_table, NULL);
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index ca84cede23..767beebe06 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -50,6 +50,11 @@ static void of_device_make_bus_id(struct device_d *dev)
> const __be32 *reg;
> u64 addr;
>
> + if (!node->parent) {
> + dev_set_name(dev, "dt-root.of");
> + return;
> + }
...and one of the few things that it actually does needs patching.
Please open code creating and registering the device for the root node.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-08-17 4:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 8:55 Oleksij Rempel
2020-08-12 9:42 ` Sascha Hauer
2020-08-12 12:40 ` Ahmad Fatoum
2020-08-12 13:08 ` Ahmad Fatoum
2020-08-12 15:13 ` Oleksij Rempel
2020-08-12 15:37 ` Ahmad Fatoum
2020-08-12 16:11 ` Oleksij Rempel
2020-08-12 18:15 ` Ahmad Fatoum
2020-08-12 18:24 ` Lucas Stach
2020-08-13 4:45 ` Oleksij Rempel
2020-08-17 4:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817044535.GC19745@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox