From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] of: base: move memory init from DT to initcall
Date: Mon, 17 Aug 2020 08:06:47 +0200 [thread overview]
Message-ID: <20200817060647.GO13023@pengutronix.de> (raw)
In-Reply-To: <20200816214300.137240-1-dev@lynxeye.de>
Hi Lucas,
On Sun, Aug 16, 2020 at 11:43:00PM +0200, Lucas Stach wrote:
> Instead of calling it from of_probe, convert it to a initcall at
> the appropriate level. This allows to move of_probe to later in
> the init sequence while keeping the memory init at the same place,
> which is important as many other drivers need the valid memory area
> to be set up properly.
With this the latest point where of_probe() could be called would be
one before mem_initcall, so postconsole_initcall.
On some architectures we have a driver for the SDRAM controller which
configures the RAM banks based on values read from the controller. On
others we depend on the device tree information and finally there are
cases where we have both and hope for the best that both information
sources do not clash. This is all not very nice and moving the initcall
level for registering the RAM might have undesired side effects.
In this situation I'm a bit hesitant to merge this patch when it doesn't
have a concrete user.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-08-17 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 21:43 Lucas Stach
2020-08-17 6:06 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817060647.GO13023@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox