From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org, david@protonic.nl
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v4 2/7] gpiolib: add gpio_array_to_id helper to get ID out of GPIO array
Date: Mon, 17 Aug 2020 10:19:24 +0200 [thread overview]
Message-ID: <20200817081929.2329-3-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20200817081929.2329-1-o.rempel@pengutronix.de>
Some boards provide a board version and/or ID coded by pull-up/down
resistors connected to the gpio pins (or pins which can be multiplexed
at some point as gpio). In this case every one implements own gpio id
reader function.
To avoid it, provide the common helper function to extract a value out
of provided gpio array.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/gpio/gpiolib.c | 31 +++++++++++++++++++++++++++++++
include/gpio.h | 5 +++++
2 files changed, 36 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 27674af54c..6088cadd8a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -381,6 +381,37 @@ void gpio_free_array(const struct gpio *array, size_t num)
}
EXPORT_SYMBOL_GPL(gpio_free_array);
+int gpio_array_to_id(const struct gpio *array, size_t num, u32 *val)
+{
+ u32 id = 0;
+ int ret, i;
+
+ if (num > 32)
+ return -EOVERFLOW;
+
+ ret = gpio_request_array(array, num);
+ if (ret)
+ return ret;
+
+ /* Wait until logic level will be stable */
+ udelay(5);
+ for (i = 0; i < num; i++) {
+ ret = gpio_is_active(array[i].gpio);
+ if (ret < 0)
+ goto free_array;
+ if (ret)
+ id |= 1UL << i;
+ }
+
+ *val = id;
+ ret = 0;
+
+free_array:
+ gpio_free_array(array, num);
+ return ret;
+}
+EXPORT_SYMBOL(gpio_array_to_id);
+
static int gpiochip_find_base(int start, int ngpio)
{
int i;
diff --git a/include/gpio.h b/include/gpio.h
index 98c5b93ba2..81beb47309 100644
--- a/include/gpio.h
+++ b/include/gpio.h
@@ -145,6 +145,10 @@ static inline void gpio_free_array(const struct gpio *array, size_t num)
/* GPIO can never have been requested */
WARN_ON(1);
}
+static inline int gpio_array_to_id(const struct gpio *array, size_t num, u32 *val)
+{
+ return -EINVAL;
+}
#else
int gpio_request(unsigned gpio, const char *label);
int gpio_find_by_name(const char *name);
@@ -153,6 +157,7 @@ void gpio_free(unsigned gpio);
int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
int gpio_request_array(const struct gpio *array, size_t num);
void gpio_free_array(const struct gpio *array, size_t num);
+int gpio_array_to_id(const struct gpio *array, size_t num, u32 *val);
#endif
struct gpio_chip;
--
2.28.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-08-17 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:19 [PATCH v4 0/7] prepare Protonic board code for mainline Oleksij Rempel
2020-08-17 8:19 ` [PATCH v4 1/7] of: base: register DT root as device Oleksij Rempel
2020-08-17 8:19 ` Oleksij Rempel [this message]
2020-08-17 8:19 ` [PATCH v4 3/7] common: console_common: add of_console_get_by_alias() helper Oleksij Rempel
2020-08-17 8:19 ` [PATCH v4 4/7] of: of_device_get_match_compatible() helper Oleksij Rempel
2020-08-17 8:19 ` [PATCH v4 5/7] ARM: protonic-imx6: port Protonic specific board code Oleksij Rempel
2020-08-19 6:27 ` Sascha Hauer
2020-08-19 8:01 ` David Jander
2020-08-17 8:19 ` [PATCH v4 6/7] ARM: dts: unify barebox and barebox, env partitions for all Protonic boards Oleksij Rempel
2020-08-17 8:19 ` [PATCH v4 7/7] ARM: dts: imx6q-prti6q: add pstore/ramoops node Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817081929.2329-3-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=david@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox