mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lars Pedersen <lapeddk@gmail.com>
Cc: barebox@lists.infradead.org, a.fatoum@pengutronix.de
Subject: Re: [PATCH] arm: imx: RELOCATABLE default yes on IMX_MULTI_BOARDS
Date: Wed, 19 Aug 2020 08:45:00 +0200	[thread overview]
Message-ID: <20200819064500.GO13023@pengutronix.de> (raw)
In-Reply-To: <20200817110346.118450-1-lapeddk@gmail.com>

Hi Lars,

On Mon, Aug 17, 2020 at 01:03:46PM +0200, Lars Pedersen wrote:
> Set relocatable to default yes when compiling for multiple i.MX boards,
> since setting a suitable TEXT_BASE value across multiple boards is impossible.
> 
> Signed-off-by: Lars Pedersen <lapeddk@gmail.com>
> ---
>  common/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 658437f01..c37339793 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -349,6 +349,7 @@ config KALLSYMS
>  config RELOCATABLE
>  	depends on PPC || ARM
>  	bool "generate relocatable barebox binary"
> +	default y if IMX_MULTI_BOARDS

I would rather just select RELOCATABLE from IMX_MULTI_BOARDS. This makes
it impossible to deselect RELOCATABLE for many boards, but I can't think
of any valid case where this is really needed, at least not in mainline.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-08-19  6:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 11:03 Lars Pedersen
2020-08-19  6:45 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819064500.GO13023@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=lapeddk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox