From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, Bastian Krause <bst@pengutronix.de>
Subject: Re: [PATCH] watchdog: fix watchdog_set_timeout breakage for drivers like imxwd
Date: Wed, 19 Aug 2020 09:33:27 +0200 [thread overview]
Message-ID: <20200819073326.GR13023@pengutronix.de> (raw)
In-Reply-To: <1596f917-83af-a467-e1ee-02c83a309b7d@pengutronix.de>
On Wed, Aug 19, 2020 at 09:18:44AM +0200, Ahmad Fatoum wrote:
> On 8/19/20 8:59 AM, Sascha Hauer wrote:
> > Hi Ahmad,
> >
> > On Tue, Aug 18, 2020 at 03:18:16PM +0200, Ahmad Fatoum wrote:
> >> Commit 0b944fce55f4 ("watchdog: permit `wd 0` for non-stoppable, but
> >> inactive, watchdogs") silently broke use of non-stoppable, but inactive,
> >> watchdogs altogether.
> >
> > Didn't this commit break *all* watchdogs? With 0b944fce55f4 an inactive
> > watchdog will never be activated anymore.
>
> watchdog_hw_running() returns -ENOSYS for watchdog that don't report whether
> they are running, so it broke all those who do report it and are inactive at
> driver probe time.
Ah, I see. I didn't look at the implementation of watchdog_hw_running().
The code explicitly tested for a boolean result, so it seemed obvious to
me that this function returns either true or false, but not an error.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-08-19 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 13:18 Ahmad Fatoum
2020-08-19 6:59 ` Sascha Hauer
2020-08-19 7:18 ` Ahmad Fatoum
2020-08-19 7:33 ` Sascha Hauer [this message]
2020-08-19 7:38 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819073326.GR13023@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=bst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox