From: Sascha Hauer <s.hauer@pengutronix.de>
To: Maik Otto <m.otto@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arch: arm: mach-imx: Add habv4 config file for i.MX6ULL
Date: Mon, 14 Sep 2020 10:44:56 +0200 [thread overview]
Message-ID: <20200914084456.GM4498@pengutronix.de> (raw)
In-Reply-To: <1599809857-266934-3-git-send-email-m.otto@phytec.de>
Hi Maik,
On Fri, Sep 11, 2020 at 09:37:37AM +0200, Maik Otto wrote:
> The i.MX6ULL has no CAAM engine for Secure Boot on HABv4 (NXP AN4581).
> For i.MX6ULL the engine Software (SW) must used for the image
> validation.
>
> +++ b/arch/arm/boards/phytec-som-imx6/flash-header-phytec-pcl063ull-512mb.imxcfg
> @@ -1,3 +1,3 @@
>
> #include "flash-header-phytec-pcl063-512mb.h"
> -#include <mach/habv4-imx6-gencsf.h>
> +#include <mach/habv4-imx6ull-gencsf.h>
> diff --git a/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h b/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h
> index 17c4d79..ee21e0b 100644
> --- a/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h
> +++ b/arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h
I would prefer to rename this file to habv4-imx6-gencsf-template.h and
let it start with:
#ifndef SETUP_HABV4_ENGINE
#error "SETUP_HABV4_ENGINE undefined"
#endif
The habv4-imx6-gencsf.h would then only set the defines and include the
template file like you already did for the i.MX6ULL.
This makes it more clear what defines the file expects.
> @@ -14,7 +14,11 @@ hab Hash Algorithm = sha256
> hab Engine Configuration = 0
> hab Certificate Format = X509
> hab Signature Format = CMS
> +#ifndef SETUP_HABV4_ENGINE
> hab Engine = CAAM
> +#else
> +hab Engine = SETUP_HABV4_ENGINE
> +#endif
>
> hab [Install SRK]
> hab File = CONFIG_HABV4_TABLE_BIN
> @@ -28,8 +32,12 @@ hab File = CONFIG_HABV4_CSF_CRT_PEM
> hab [Authenticate CSF]
>
> hab [Unlock]
> +#ifndef SETUP_HABV4_ENGINE
> hab Engine = CAAM
> hab Features = RNG, MID
> +#else
> +hab Engine = SETUP_HABV4_ENGINE
> +#endif
Do we need this #ifdef here? Can't we instead have a
SETUP_HABV4_FEATURES macro and let the SoC specific files define it as
#define SETUP_HABV4_FEATURES RNG,MID
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-09-14 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 7:37 [PATCH v2 0/2] i.MX6ULL: set engine software for Secure Boot on HABv4 Maik Otto
2020-09-11 7:37 ` [PATCH v2 1/2] arch: arm: boards phytec: Split flash header for pcl063 with i.MX6Ul and i.MX6ULL Maik Otto
2020-09-11 7:37 ` [PATCH v2 2/2] arch: arm: mach-imx: Add habv4 config file for i.MX6ULL Maik Otto
2020-09-14 8:44 ` Sascha Hauer [this message]
2020-09-17 9:35 ` Maik Otto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914084456.GM4498@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.otto@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox