From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIAXF-0005aY-Q0 for barebox@lists.infradead.org; Tue, 15 Sep 2020 12:58:14 +0000 Date: Tue, 15 Sep 2020 14:58:11 +0200 From: Sascha Hauer Message-ID: <20200915125811.GO4498@pengutronix.de> References: <20200909193650.347646-1-trent.piepho@synapse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200909193650.347646-1-trent.piepho@synapse.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/4] aiodev: Name channels with device instance name To: Trent Piepho Cc: barebox@lists.infradead.org On Wed, Sep 09, 2020 at 12:36:47PM -0700, Trent Piepho wrote: > When dynamically assigning device names, an aiodev's name will be > "aiodev" and an index, not part of the name string itself, will be > allocated dynamically. These are combined to register a device with a > name like "aiodev0" or "aiodev1". > > The shell environment variables use the device name, so one might use > "${aiodev0.in_value0_mV}" and "${aiodev1.in_value0_mV}". > > However, the channel names that are used with aiochannel_get_by_name() > just use the aiodev's name and channel name. So channel 0 of the 1st > aiodev would be "aiodev.in_value0_mV" and the 2nd aiodev would use the > same name. > > Change the channel naming to use the device instance name, e.g. > "aiodev0", rather than the aiodev's base name. This makes the names > used aiochannel_get_by_name() match the environment variable names and > also avoids duplicate names with more than one dynamically allocated > aiodev. > > Signed-off-by: Trent Piepho > --- > drivers/aiodev/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good to go from my side, so with Ahmads comments fixed we can merge this series. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox