From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, lst@pengutronix.de, jbe@pengutronix.de
Subject: Re: [PATCH master] ARM: psci: fix NULL pointer dereference on CPU idle
Date: Fri, 2 Oct 2020 06:22:51 +0200 [thread overview]
Message-ID: <20201002042251.GT11648@pengutronix.de> (raw)
In-Reply-To: <20200930135603.8250-1-a.fatoum@pengutronix.de>
On Wed, Sep 30, 2020 at 03:56:03PM +0200, Ahmad Fatoum wrote:
> We guard against cpu_off being NULL, but dereference cpu_suspend
> instead.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Cc: lst@pengutronix.de
> Cc: jbe@pengutronix.de
> Cc: jlu@pengutronix.de
> ---
> arch/arm/cpu/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/cpu/psci.c b/arch/arm/cpu/psci.c
> index 436561f8649f..d1056e0659da 100644
> --- a/arch/arm/cpu/psci.c
> +++ b/arch/arm/cpu/psci.c
> @@ -89,7 +89,7 @@ static unsigned long psci_cpu_suspend(u32 power_state, unsigned long entry,
> {
> psci_printf("%s\n", __func__);
>
> - if (psci_ops->cpu_off)
> + if (psci_ops->cpu_suspend)
> return psci_ops->cpu_suspend(power_state, entry, context_id);
>
> return ARM_PSCI_RET_NOT_SUPPORTED;
> --
> 2.28.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-10-02 4:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 13:56 Ahmad Fatoum
2020-10-02 4:22 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002042251.GT11648@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
--cc=lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox