* [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE
@ 2020-10-02 11:14 Marco Felsch
2020-10-02 11:23 ` Lucas Stach
0 siblings, 1 reply; 4+ messages in thread
From: Marco Felsch @ 2020-10-02 11:14 UTC (permalink / raw)
To: barebox
All barebox images should be relocatable per default. The user needs to
turn of this option on purpose rather than turning it on. Currently this
option was selected by selecting MACH_CCMX51. Deselecting this board
support ended in deselecting CONFIG_RELOCATABLE.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
arch/arm/configs/imx_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v7_defconfig b/arch/arm/configs/imx_v7_defconfig
index 5dcdff0638..c55df0357d 100644
--- a/arch/arm/configs/imx_v7_defconfig
+++ b/arch/arm/configs/imx_v7_defconfig
@@ -208,3 +208,4 @@ CONFIG_FS_FAT_LFN=y
CONFIG_FS_UBIFS=y
CONFIG_FS_UBIFS_COMPRESSION_LZO=y
CONFIG_PNG=y
+CONFIG_RELOCATABLE=y
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE
2020-10-02 11:14 [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE Marco Felsch
@ 2020-10-02 11:23 ` Lucas Stach
2020-10-02 12:07 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2020-10-02 11:23 UTC (permalink / raw)
To: Marco Felsch, barebox
On Fr, 2020-10-02 at 13:14 +0200, Marco Felsch wrote:
> All barebox images should be relocatable per default. The user needs to
> turn of this option on purpose rather than turning it on. Currently this
> option was selected by selecting MACH_CCMX51. Deselecting this board
> support ended in deselecting CONFIG_RELOCATABLE.
Shouldn't this rather be selected by IMX_MULTI_BOARDS or soemthing
similar? Otherwise one would need to find a ARCH_TEXT_BASE compatible
with all the enabled boards, which is probably a bit too much config
hell to dump onto the users.
Regards,
Lucas
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> arch/arm/configs/imx_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v7_defconfig b/arch/arm/configs/imx_v7_defconfig
> index 5dcdff0638..c55df0357d 100644
> --- a/arch/arm/configs/imx_v7_defconfig
> +++ b/arch/arm/configs/imx_v7_defconfig
> @@ -208,3 +208,4 @@ CONFIG_FS_FAT_LFN=y
> CONFIG_FS_UBIFS=y
> CONFIG_FS_UBIFS_COMPRESSION_LZO=y
> CONFIG_PNG=y
> +CONFIG_RELOCATABLE=y
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE
2020-10-02 11:23 ` Lucas Stach
@ 2020-10-02 12:07 ` Sascha Hauer
2020-10-02 13:06 ` Marco Felsch
0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2020-10-02 12:07 UTC (permalink / raw)
To: Lucas Stach; +Cc: barebox, Marco Felsch
On Fri, Oct 02, 2020 at 01:23:19PM +0200, Lucas Stach wrote:
> On Fr, 2020-10-02 at 13:14 +0200, Marco Felsch wrote:
> > All barebox images should be relocatable per default. The user needs to
> > turn of this option on purpose rather than turning it on. Currently this
> > option was selected by selecting MACH_CCMX51. Deselecting this board
> > support ended in deselecting CONFIG_RELOCATABLE.
>
> Shouldn't this rather be selected by IMX_MULTI_BOARDS or soemthing
> similar? Otherwise one would need to find a ARCH_TEXT_BASE compatible
> with all the enabled boards, which is probably a bit too much config
> hell to dump onto the users.
This option actually is selected by IMX_MULTI_BOARDS, see recently added
ca3286135e ("arm: imx: Select RELOCATABLE on IMX_MULTI_BOARDS")
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE
2020-10-02 12:07 ` Sascha Hauer
@ 2020-10-02 13:06 ` Marco Felsch
0 siblings, 0 replies; 4+ messages in thread
From: Marco Felsch @ 2020-10-02 13:06 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 20-10-02 14:07, Sascha Hauer wrote:
> On Fri, Oct 02, 2020 at 01:23:19PM +0200, Lucas Stach wrote:
> > On Fr, 2020-10-02 at 13:14 +0200, Marco Felsch wrote:
> > > All barebox images should be relocatable per default. The user needs to
> > > turn of this option on purpose rather than turning it on. Currently this
> > > option was selected by selecting MACH_CCMX51. Deselecting this board
> > > support ended in deselecting CONFIG_RELOCATABLE.
> >
> > Shouldn't this rather be selected by IMX_MULTI_BOARDS or soemthing
> > similar? Otherwise one would need to find a ARCH_TEXT_BASE compatible
> > with all the enabled boards, which is probably a bit too much config
> > hell to dump onto the users.
Thought about the this solution too and seems to be better.
> This option actually is selected by IMX_MULTI_BOARDS, see recently added
> ca3286135e ("arm: imx: Select RELOCATABLE on IMX_MULTI_BOARDS")
I see, unfortunately it didn't made it into v2020.09.0. Pls, ignore this
patch.
Regards,
Marco
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-02 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 11:14 [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE Marco Felsch
2020-10-02 11:23 ` Lucas Stach
2020-10-02 12:07 ` Sascha Hauer
2020-10-02 13:06 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox