From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLAb-0001b9-Gd for barebox@lists.infradead.org; Fri, 02 Oct 2020 13:32:22 +0000 Date: Fri, 2 Oct 2020 15:32:17 +0200 From: Marco Felsch Message-ID: <20201002133217.afkkdngxfehoesvo@pengutronix.de> References: <20201002105635.4662-1-m.felsch@pengutronix.de> <20201002105635.4662-3-m.felsch@pengutronix.de> <1b203cf29de7969001d0ea9db8dd5b8dcc3e4759.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1b203cf29de7969001d0ea9db8dd5b8dcc3e4759.camel@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] ARCH: i.MX6: add support for OFDEVICE To: Lucas Stach Cc: barebox@lists.infradead.org On 20-10-02 13:26, Lucas Stach wrote: > On Fr, 2020-10-02 at 12:56 +0200, Marco Felsch wrote: > > The imx23_defconfig, imx_v8_defconfig and imx_defconfig already > > selecting this config except for the imx_v7_defconfig. The > > imx_v7_defconfig selects MACH_ZII_VF610_DEV which selects ARCH_VF610 > > which select OFDEVICE. So it will be never selected if the > > MACH_ZII_VF610_DEV board support is dropped. > > > > Selecting the option here seems to be the better place instead of > > adding > > it to the imx_v7_defconfig because there are possible no i.MX6 boards > > not > > using the device tree. > > > > Signed-off-by: Marco Felsch > > --- > > arch/arm/mach-imx/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > > index a1127e3707..a4b0f99e96 100644 > > --- a/arch/arm/mach-imx/Kconfig > > +++ b/arch/arm/mach-imx/Kconfig > > @@ -146,7 +146,7 @@ config ARCH_IMX6 > > select ARCH_HAS_IMX_GPT > > select CPU_V7 > > select PINCTRL_IMX_IOMUX_V3 > > - select OFTREE > > + select OFDEVICE > > Kconfig selects are not recursive, so you still need to keep the OFTREE > select here, otherwise you might end up with a broken dependency for > OFDEVICE. I checked the Kbuild docu and found: https://www.kernel.org/doc/html/latest/kbuild/issues.html, #Issue1. This example shows that select is recursive. The documentations also points out that select don't check the depends on. So this change seems to be valid since OFDEVICE don't has any dependcies. Regards, Marco _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox