The cm-fx6 board uses the edhc-pbl function during lowlevel init. So we need to select it. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm/mach-imx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index a67e59fd4f..1e4ba0bca4 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -450,6 +450,7 @@ config MACH_GW_VENTANA config MACH_CM_FX6 bool "CM FX6" select ARCH_IMX6 + select MCI_IMX_ESDHC_PBL config MACH_ADVANTECH_ROM_742X bool "Advantech ROM 742X" -- 2.20.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Both dependencies are covered by ARCH_IMX6 so we no longer need to mention them here too. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm/mach-imx/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index 1e4ba0bca4..a1127e3707 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -157,8 +157,6 @@ config ARCH_IMX6SL config ARCH_IMX6SX bool select ARCH_IMX6 - select OFTREE - select COMMON_CLK_OF_PROVIDER config ARCH_IMX6UL bool -- 2.20.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
The imx23_defconfig, imx_v8_defconfig and imx_defconfig already selecting this config except for the imx_v7_defconfig. The imx_v7_defconfig selects MACH_ZII_VF610_DEV which selects ARCH_VF610 which select OFDEVICE. So it will be never selected if the MACH_ZII_VF610_DEV board support is dropped. Selecting the option here seems to be the better place instead of adding it to the imx_v7_defconfig because there are possible no i.MX6 boards not using the device tree. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm/mach-imx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index a1127e3707..a4b0f99e96 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -146,7 +146,7 @@ config ARCH_IMX6 select ARCH_HAS_IMX_GPT select CPU_V7 select PINCTRL_IMX_IOMUX_V3 - select OFTREE + select OFDEVICE select COMMON_CLK_OF_PROVIDER select HW_HAS_PCI -- 2.20.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
On Fr, 2020-10-02 at 12:56 +0200, Marco Felsch wrote: > The imx23_defconfig, imx_v8_defconfig and imx_defconfig already > selecting this config except for the imx_v7_defconfig. The > imx_v7_defconfig selects MACH_ZII_VF610_DEV which selects ARCH_VF610 > which select OFDEVICE. So it will be never selected if the > MACH_ZII_VF610_DEV board support is dropped. > > Selecting the option here seems to be the better place instead of > adding > it to the imx_v7_defconfig because there are possible no i.MX6 boards > not > using the device tree. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > arch/arm/mach-imx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index a1127e3707..a4b0f99e96 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig > @@ -146,7 +146,7 @@ config ARCH_IMX6 > select ARCH_HAS_IMX_GPT > select CPU_V7 > select PINCTRL_IMX_IOMUX_V3 > - select OFTREE > + select OFDEVICE Kconfig selects are not recursive, so you still need to keep the OFTREE select here, otherwise you might end up with a broken dependency for OFDEVICE. Regards, Lucas > select COMMON_CLK_OF_PROVIDER > select HW_HAS_PCI > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
On 20-10-02 13:26, Lucas Stach wrote: > On Fr, 2020-10-02 at 12:56 +0200, Marco Felsch wrote: > > The imx23_defconfig, imx_v8_defconfig and imx_defconfig already > > selecting this config except for the imx_v7_defconfig. The > > imx_v7_defconfig selects MACH_ZII_VF610_DEV which selects ARCH_VF610 > > which select OFDEVICE. So it will be never selected if the > > MACH_ZII_VF610_DEV board support is dropped. > > > > Selecting the option here seems to be the better place instead of > > adding > > it to the imx_v7_defconfig because there are possible no i.MX6 boards > > not > > using the device tree. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > arch/arm/mach-imx/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > > index a1127e3707..a4b0f99e96 100644 > > --- a/arch/arm/mach-imx/Kconfig > > +++ b/arch/arm/mach-imx/Kconfig > > @@ -146,7 +146,7 @@ config ARCH_IMX6 > > select ARCH_HAS_IMX_GPT > > select CPU_V7 > > select PINCTRL_IMX_IOMUX_V3 > > - select OFTREE > > + select OFDEVICE > > Kconfig selects are not recursive, so you still need to keep the OFTREE > select here, otherwise you might end up with a broken dependency for > OFDEVICE. I checked the Kbuild docu and found: https://www.kernel.org/doc/html/latest/kbuild/issues.html, #Issue1. This example shows that select is recursive. The documentations also points out that select don't check the depends on. So this change seems to be valid since OFDEVICE don't has any dependcies. Regards, Marco _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
On Fri, Oct 02, 2020 at 12:56:33PM +0200, Marco Felsch wrote: > The cm-fx6 board uses the edhc-pbl function during lowlevel init. So we > need to select it. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > arch/arm/mach-imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied, thanks Sascha > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index a67e59fd4f..1e4ba0bca4 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig > @@ -450,6 +450,7 @@ config MACH_GW_VENTANA > config MACH_CM_FX6 > bool "CM FX6" > select ARCH_IMX6 > + select MCI_IMX_ESDHC_PBL > > config MACH_ADVANTECH_ROM_742X > bool "Advantech ROM 742X" > -- > 2.20.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox