mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: stm32_sdmmc2: add support for SDMMC v2.0 as well
@ 2020-10-20 16:52 Ahmad Fatoum
  2020-10-21 10:00 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2020-10-20 16:52 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

According to kernel commit 7a2a98be672b ("mmc: mmci: Add support for
sdmmc variant revision 2.0")[0], v2.0 is completely backwards compatible
with v1.1. Add the v2.0's periphid to have the driver work with both.

[0]: https://lore.kernel.org/linux-arm-kernel/20200128090636.13689-10-ludovic.barre@st.com/T/#u
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/stm32_sdmmc2.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c
index da2dc592adb3..0c620427ee44 100644
--- a/drivers/mci/stm32_sdmmc2.c
+++ b/drivers/mci/stm32_sdmmc2.c
@@ -633,11 +633,16 @@ priv_free:
 }
 
 static struct amba_id stm32_sdmmc2_ids[] = {
-	/* ST Micro STM32MP157C */
+	/* ST Micro STM32MP15 v1.1 */
 	{
 		.id     = 0x10153180,
 		.mask	= 0xf0ffffff,
 	},
+	/* ST Micro STM32MP15 v2.0 */
+	{
+		.id     = 0x00253180,
+		.mask	= 0xf0ffffff,
+	},
 	{ 0, 0 },
 };
 
-- 
2.28.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mci: stm32_sdmmc2: add support for SDMMC v2.0 as well
  2020-10-20 16:52 [PATCH] mci: stm32_sdmmc2: add support for SDMMC v2.0 as well Ahmad Fatoum
@ 2020-10-21 10:00 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-10-21 10:00 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Tue, Oct 20, 2020 at 06:52:14PM +0200, Ahmad Fatoum wrote:
> According to kernel commit 7a2a98be672b ("mmc: mmci: Add support for
> sdmmc variant revision 2.0")[0], v2.0 is completely backwards compatible
> with v1.1. Add the v2.0's periphid to have the driver work with both.
> 
> [0]: https://lore.kernel.org/linux-arm-kernel/20200128090636.13689-10-ludovic.barre@st.com/T/#u
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mci/stm32_sdmmc2.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c
> index da2dc592adb3..0c620427ee44 100644
> --- a/drivers/mci/stm32_sdmmc2.c
> +++ b/drivers/mci/stm32_sdmmc2.c
> @@ -633,11 +633,16 @@ priv_free:
>  }
>  
>  static struct amba_id stm32_sdmmc2_ids[] = {
> -	/* ST Micro STM32MP157C */
> +	/* ST Micro STM32MP15 v1.1 */
>  	{
>  		.id     = 0x10153180,
>  		.mask	= 0xf0ffffff,
>  	},
> +	/* ST Micro STM32MP15 v2.0 */
> +	{
> +		.id     = 0x00253180,
> +		.mask	= 0xf0ffffff,
> +	},
>  	{ 0, 0 },
>  };
>  
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-21 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 16:52 [PATCH] mci: stm32_sdmmc2: add support for SDMMC v2.0 as well Ahmad Fatoum
2020-10-21 10:00 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox